Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically updates the Python version requirements across multiple packages within the repository. The core objective is to deprecate support for Python 3.7 and 3.8, establishing Python 3.9 as the new minimum supported version. This change is reflected in various configuration files, build scripts, and documentation, ensuring consistency with current Python ecosystem standards and end-of-life policies. The update also includes a simplification of testing configurations by removing specific protobuf implementation tests that are no longer relevant or supported. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates multiple packages to require Python 3.9 as the minimum version, dropping support for Python 3.7 and 3.8. The changes are extensive, touching configuration files (setup.py, noxfile.py), documentation (README.rst, CONTRIBUTING.rst), and testing infrastructure (constraints-*.txt). The updates are largely consistent and correct across all affected packages. I've pointed out a couple of minor issues in the new testing constraints files for your consideration.
| # | ||
| # e.g., if setup.py has "foo >= 1.14.0, < 2.0.0dev", | ||
| # Then this file should have foo==1.14.0 | ||
|
|
| # Then this file should have foo==1.14.0 | ||
| click==7.0.0 | ||
| google-auth==0.4.0 | ||
| importlib_metadata==1.0.0 |
There was a problem hiding this comment.
No description provided.