chore: librarian update image pull request: 20260314T000229Z#16108
Open
chore: librarian update image pull request: 20260314T000229Z#16108
Conversation
…prod/images-prod/python-librarian-generator@sha256:c5699d10addd7c32f45569a3eddc624bf68731095922cf9db0fda5352f849bf5
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically updates Python dependency versions across several Google Cloud client libraries, primarily within the Highlights
Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This PR updates the generator image and applies a large number of automated changes across many packages. The changes include dependency updates, dropping support for Python 3.7 and 3.8, and various code quality improvements like adding type hints and correctness fixes.
Overall, the changes look good, but I've found a few critical issues that will likely break the CI builds:
- The
grpcioversion constraints innoxfile.pyfor several packages seem to be incorrect, referencing a non-existent version (1.75.1) and using a potentially problematic upper bound (<=1.62.2). - A post-processing rule in
logging-integration.yamlappears to be misconfigured and will incorrectly remove the entiremypysession from thegoogle-cloud-loggingnoxfile.
Please address these issues. The noxfile.py issue is present in multiple packages (google-ads-admanager, google-ads-datamanager, google-ads-marketingplatform-admin).
Comment on lines
477
to
485
| before: | | ||
| """Run the type checker.""" | ||
| [\s\S]*?"google",\n \) | ||
| [\s\S]*?"google", | ||
| \ "--check-untyped-defs", | ||
| \ \*session.posargs, | ||
| \ \) | ||
| after: | | ||
| """Run the type checker.""" | ||
|
|
Contributor
There was a problem hiding this comment.
This replacement rule appears to be incorrectly configured. It will find the mypy call in packages/google-cloud-logging/noxfile.py and replace it entirely with just the docstring, effectively removing the type checking session. This is likely not the intended behavior. Perhaps the goal was to comment out --check-untyped-defs as seen in other configuration files?
Comment on lines
+285
to
+288
| if session.python >= "3.12": | ||
| session.install("--pre", "grpcio>=1.75.1") | ||
| else: | ||
| session.install("--pre", "grpcio<=1.62.2") |
Contributor
There was a problem hiding this comment.
The specified grpcio version >=1.75.1 for Python 3.12+ does not appear to exist on PyPI, which will likely cause installation failures. The latest version is 1.64.1. Was this a typo? Additionally, pinning grpcio to <=1.62.2 for older Python versions might be overly restrictive and prevent the use of newer patch or minor releases that are still compatible.
| "google-auth", | ||
| "grpc-google-iam-v1", | ||
| "grpcio", | ||
| "grpcio>=1.75.1" if session.python >= "3.12" else "grpcio<=1.62.2", |
Contributor
There was a problem hiding this comment.
Similar to the install_systemtest_dependencies session, the grpcio version requirement seems incorrect. Version >=1.75.1 for Python 3.12+ is not available on PyPI, and pinning to <=1.62.2 for older Python versions could be problematic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c5699d10addd7c32f45569a3eddc624bf68731095922cf9db0fda5352f849bf5
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
feat: Allow Protobuf 7.x
fix: Require Python 3.9
fix: Require google-api-core >= 2.11.0
fix: Improve type checking
PiperOrigin-RevId: 0
Library-IDs: google-ads-admanager,google-ads-datamanager,google-ads-marketingplatform-admin,google-ai-generativelanguage,google-analytics-admin,google-analytics-data,google-apps-card,google-apps-chat,google-apps-events-subscriptions,google-apps-meet,google-apps-script-type,google-area120-tables,google-cloud-access-approval,google-cloud-advisorynotifications,google-cloud-alloydb,google-cloud-alloydb-connectors,google-cloud-api-gateway,google-cloud-apigee-connect,google-cloud-apigee-registry,google-cloud-apihub,google-cloud-api-keys,google-cloud-apiregistry,google-cloud-appengine-admin,google-cloud-appengine-logging,google-cloud-apphub,google-cloud-artifact-registry,google-cloud-asset,google-cloud-assured-workloads,google-cloud-auditmanager,google-cloud-automl,google-cloud-backupdr,google-cloud-bare-metal-solution,google-cloud-batch,google-cloud-beyondcorp-appconnections,google-cloud-beyondcorp-appconnectors,google-cloud-beyondcorp-appgateways,google-cloud-beyondcorp-clientconnectorservices,google-cloud-beyondcorp-clientgateways,google-cloud-biglake,google-cloud-bigquery-analyticshub,google-cloud-bigquery-biglake,google-cloud-bigquery-connection,google-cloud-bigquery-data-exchange,google-cloud-bigquery-datapolicies,google-cloud-bigquery-datatransfer,google-cloud-bigquery-logging,google-cloud-bigquery-migration,google-cloud-bigquery-reservation,google-cloud-bigquery-storage,google-cloud-billing,google-cloud-billing-budgets,google-cloud-binary-authorization,google-cloud-build,google-cloud-capacityplanner,google-cloud-certificate-manager,google-cloud-ces,google-cloud-channel,google-cloud-chronicle,google-cloud-cloudcontrolspartner,google-cloud-cloudsecuritycompliance,google-cloud-commerce-consumer-procurement,google-cloud-common,google-cloud-compute,google-cloud-compute-v1beta,google-cloud-confidentialcomputing,google-cloud-config,google-cloud-configdelivery,google-cloud-contact-center-insights,google-cloud-container,google-cloud-containeranalysis,google-cloud-contentwarehouse,google-cloud-databasecenter,google-cloud-datacatalog,google-cloud-datacatalog-lineage,google-cloud-dataflow-client,google-cloud-dataform,google-cloud-data-fusion,google-cloud-datalabeling,google-cloud-dataplex,google-cloud-dataproc,google-cloud-dataproc-metastore,google-cloud-data-qna,google-cloud-datastore,google-cloud-datastream,google-cloud-deploy,google-cloud-developerconnect,google-cloud-devicestreaming,google-cloud-dialogflow,google-cloud-dialogflow-cx,google-cloud-dlp,google-cloud-dms,google-cloud-documentai,google-cloud-domains,google-cloud-edgecontainer,google-cloud-edgenetwork,google-cloud-enterpriseknowledgegraph,google-cloud-error-reporting,google-cloud-essential-contacts,google-cloud-eventarc,google-cloud-eventarc-publishing,google-cloud-filestore,google-cloud-financialservices,google-cloud-firestore,google-cloud-functions,google-cloud-gdchardwaremanagement,google-cloud-geminidataanalytics,google-cloud-gke-backup,google-cloud-gke-connect-gateway,google-cloud-gke-hub,google-cloud-gke-multicloud,google-cloud-gkerecommender,google-cloud-gsuiteaddons,google-cloud-hypercomputecluster,google-cloud-iam,google-cloud-iam-logging,google-cloud-iap,google-cloud-ids,google-cloud-kms,google-cloud-kms-inventory,google-cloud-language,google-cloud-licensemanager,google-cloud-life-sciences,google-cloud-locationfinder,google-cloud-logging,google-cloud-lustre,google-cloud-maintenance-api,google-cloud-managed-identities,google-cloud-managedkafka,google-cloud-managedkafka-schemaregistry,google-cloud-media-translation,google-cloud-memcache,google-cloud-memorystore,google-cloud-migrationcenter,google-cloud-modelarmor,google-cloud-monitoring,google-cloud-monitoring-dashboards,google-cloud-monitoring-metrics-scopes,google-cloud-netapp,google-cloud-network-connectivity,google-cloud-network-management,google-cloud-network-security,google-cloud-network-services,google-cloud-notebooks,google-cloud-optimization,google-cloud-oracledatabase,google-cloud-orchestration-airflow,google-cloud-org-policy,google-cloud-os-config,google-cloud-os-login,google-cloud-parallelstore,google-cloud-parametermanager,google-cloud-phishing-protection,google-cloud-policysimulator,google-cloud-policy-troubleshooter,google-cloud-policytroubleshooter-iam,google-cloud-private-ca,google-cloud-private-catalog,google-cloud-privilegedaccessmanager,google-cloud-quotas,google-cloud-rapidmigrationassessment,google-cloud-recaptcha-enterprise,google-cloud-recommendations-ai,google-cloud-recommender,google-cloud-redis,google-cloud-redis-cluster,google-cloud-resource-manager,google-cloud-retail,google-cloud-run,google-cloud-saasplatform-saasservicemgmt,google-cloud-scheduler,google-cloud-secret-manager,google-cloud-securesourcemanager,google-cloud-securitycenter,google-cloud-securitycentermanagement,google-cloud-security-publicca,google-cloud-service-control,google-cloud-service-directory,google-cloud-servicehealth,google-cloud-service-management,google-cloud-service-usage,google-cloud-shell,google-cloud-source-context,google-cloud-speech,google-cloud-storagebatchoperations,google-cloud-storage-control,google-cloud-storageinsights,google-cloud-storage-transfer,google-cloud-support,google-cloud-talent,google-cloud-tasks,google-cloud-telcoautomation,google-cloud-texttospeech,google-cloud-tpu,google-cloud-trace,google-cloud-translate,google-cloud-vectorsearch,google-cloud-videointelligence,google-cloud-video-live-stream,google-cloud-video-stitcher,google-cloud-video-transcoder,google-cloud-vision,google-cloud-visionai,google-cloud-vm-migration,google-cloud-vmwareengine,google-cloud-vpc-access,google-cloud-webrisk,google-cloud-websecurityscanner,google-cloud-workflows,google-cloud-workloadmanager,google-cloud-workstations,google-geo-type,google-maps-addressvalidation,google-maps-areainsights,google-maps-fleetengine,google-maps-fleetengine-delivery,google-maps-mapsplatformdatasets,google-maps-places,google-maps-routeoptimization,google-maps-routing,google-maps-solar,google-shopping-css,google-shopping-merchant-accounts,google-shopping-merchant-conversions,google-shopping-merchant-datasources,google-shopping-merchant-inventories,google-shopping-merchant-issueresolution,google-shopping-merchant-lfp,google-shopping-merchant-notifications,google-shopping-merchant-ordertracking,google-shopping-merchant-products,google-shopping-merchant-productstudio,google-shopping-merchant-promotions,google-shopping-merchant-quota,google-shopping-merchant-reports,google-shopping-merchant-reviews,google-shopping-type,grafeas
Source-link: googleapis/googleapis@0
END_NESTED_COMMIT
END_COMMIT