Skip to content

chore: increase awaitTermination timeout in ITBulkConnectionTest #4375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sakthivelmanii wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: increase awaitTermination timeout in ITBulkConnectionTest #4375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5eb9228
chore: increase awaitTermination timeout in ITBulkConnectionTest
sakthivelmanii Mar 4, 2026
b2ba7e5
fix: add delay to mock session creation in testRetryWithNoSessionCrea…
sakthivelmanii Mar 4, 2026
b121573
chore: generate libraries at Wed Mar 4 12:20:22 UTC 2026
cloud-java-bot Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...rc/test/java/com/google/cloud/spanner/MultiplexedSessionDatabaseClientMockServerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,9 @@ public void testRetryWithTheDatabaseNotFoundExceptionWithSessionCreationWaitTime
@Test
public void testRetryWithNoSessionCreationWaitTime() {
mockSpanner.setCreateSessionExecutionTime(
SimulatedExecutionTime.ofExceptions(
SimulatedExecutionTime.ofMinimumAndRandomTimeAndExceptions(
100,
0,
Collections.singletonList(
Status.DEADLINE_EXCEEDED
.withDescription(
Expand Down
2 changes: 1 addition & 1 deletion ...ud-spanner/src/test/java/com/google/cloud/spanner/connection/it/ITBulkConnectionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public void testBulkCreateConnectionsMultiThreaded() throws InterruptedException
});
}
executor.shutdown();
executor.awaitTermination(10L, TimeUnit.SECONDS);
assertThat(executor.awaitTermination(60L, TimeUnit.SECONDS), is(true));
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve readability and maintainability, it would be best to extract the magic number 60L into a named constant at the class level. This makes the purpose of the value clear and simplifies future modifications.

For example:

private static final long AWAIT_TERMINATION_TIMEOUT_SECONDS = 60L;

And then use it in the assertion:

assertThat(executor.awaitTermination(AWAIT_TERMINATION_TIMEOUT_SECONDS, TimeUnit.SECONDS), is(true));

// close Spanner instances explicitly. This method will throw an exception if there are any
// connections still open in the pool
closeSpanner();
Expand Down
Loading