Skip to content

Comments

feat(storage): add Bucket Encryption Enforcement Configuration#3502

Closed
krishnamd-jkp wants to merge 1 commit intomainfrom
go-storage-bucket-encryption-9180534767370241897
Closed

feat(storage): add Bucket Encryption Enforcement Configuration#3502
krishnamd-jkp wants to merge 1 commit intomainfrom
go-storage-bucket-encryption-9180534767370241897

Conversation

@krishnamd-jkp
Copy link

Implemented Bucket Encryption Enforcement Configuration for Go storage client.

  • Added GoogleManagedEncryptionEnforcementConfig, CustomerManagedEncryptionEnforcementConfig, CustomerSuppliedEncryptionEnforcementConfig structs.
  • Added EncryptionEnforcementRestrictionMode type and constants.
  • Updated BucketEncryption to include these configurations.
  • Implemented mapping logic for gRPC (Proto) in toProtoBucketEncryption and toBucketEncryptionFromProto.
  • Verified compilation and round-trip conversion with a local test.
  • Generated implementation.patch containing the changes for google-cloud-go repository.

PR created automatically by Jules for task 9180534767370241897 started by @krishnamd-jkp

… This change implements `GoogleManagedEncryptionEnforcementConfig`, `CustomerManagedEncryptionEnforcementConfig`, and `CustomerSuppliedEncryptionEnforcementConfig` in the Go storage client, mirroring the implementation in the Java client.

I added the corresponding structs and updated `BucketEncryption` to include them. Mapping to and from storagepb (gRPC) is implemented, while JSON API mapping is deferred until the underlying library is updated.

Since the environment was initialized with the Java repository, I performed the implementation in a separate clone and have provided the changes as a patch file named `implementation.patch`.

Co-authored-by: krishnamd-jkp <230955344+krishnamd-jkp@users.noreply.github.com>
@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@krishnamd-jkp krishnamd-jkp requested review from a team as code owners February 20, 2026 15:58
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage API. labels Feb 20, 2026
@krishnamd-jkp krishnamd-jkp deleted the go-storage-bucket-encryption-9180534767370241897 branch February 20, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/java-storage API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant