Add aarch64 Linux support (DGX Spark / GB10)#51
Open
brandonin wants to merge 1 commit intogpu-mode:mainfrom
Open
Add aarch64 Linux support (DGX Spark / GB10)#51brandonin wants to merge 1 commit intogpu-mode:mainfrom
brandonin wants to merge 1 commit intogpu-mode:mainfrom
Conversation
- Add aarch64-unknown-linux-gnu build target to the release workflow - Add .cargo/config.toml to configure the cross-linker for aarch64 - Update install.sh to detect arm64/aarch64 and download the correct binary (popcorn-cli-linux-aarch64.tar.gz) instead of the x86-64 build
There was a problem hiding this comment.
Pull request overview
Adds ARM64 (aarch64) Linux support to the release pipeline and installer so Popcorn CLI can be installed and run on machines like the NVIDIA GB10 / DGX Spark.
Changes:
- Extend the GitHub Actions build matrix to produce a
popcorn-cli-linux-aarch64.tar.gzrelease asset. - Add a Cargo target linker config for
aarch64-unknown-linux-gnuto support cross-linking on CI. - Update
install.shto detectaarch64/arm64on Linux and download the matching release artifact.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
install.sh |
Detects ARM64 Linux and selects the linux-aarch64 release asset automatically. |
.github/workflows/build.yml |
Builds and publishes an additional ARM64 Linux tarball as a release asset. |
.cargo/config.toml |
Configures the cross-linker for aarch64-unknown-linux-gnu builds (CI/local). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aarch64-unknown-linux-gnuto the release build matrix, producingpopcorn-cli-linux-aarch64.tar.gz.cargo/config.tomlto configureaarch64-linux-gnu-gccas the cross-linker on GitHub Actions runnersinstall.shto detectaarch64/arm64on Linux and download the correct binary automaticallyMotivation
The pre-built
popcorn-cli-linux.tar.gzis x86-64 only and does not run on ARM Linux machines such as the NVIDIA GB10 DGX Spark. This PR makes the install script work out of the box on those systems with no manual steps required.Test plan
popcorn-cli-linux-aarch64.tar.gzsuccessfullycurl -fsSL .../install.sh | bashon an aarch64 Linux machine and confirmpopcorn --versionworks