Feature: Add options for enforcing asset name validation (Touches #11473)#18385
Open
cram42 wants to merge 1 commit intogrokability:developfrom
Open
Feature: Add options for enforcing asset name validation (Touches #11473)#18385cram42 wants to merge 1 commit intogrokability:developfrom
cram42 wants to merge 1 commit intogrokability:developfrom
Conversation
Contributor
Author
|
Extremely confused about the failed checks. Is develop branch broken for anyone else at the moment? |
Member
|
Develop is not broken as far as I'm aware. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Touches issue #11473
We (and several others apparently) use the Asset Name as the primary identifier for assets.
Therefore it's required to be mandatory, in a specific format, and unique forever.
We also do have some assets without a name, so null values are allowed.
I've put together this quick little commit to add those options into General Settings.
Validation Checkbox - Enables the regex validation rule on asset names.
Regex Input - The regex rule itself.
Unique Checkbox - Enables the
unique_undeletedrule on asset names.Ignore Blank Checkbox - Enables the
nullablerule on asset names.For those in #11473 who are happy to just have it mandatory, enable Validation, set Regex to
regex:/^.+$/, and disable Ignore Blank.