Skip to content

Fixed #15600: Adds extra verification step on checkin of device if enabled#18538

Open
Glukose1 wants to merge 1 commit intogrokability:developfrom
Glukose1:develop
Open

Fixed #15600: Adds extra verification step on checkin of device if enabled#18538
Glukose1 wants to merge 1 commit intogrokability:developfrom
Glukose1:develop

Conversation

@Glukose1
Copy link
Copy Markdown

Fixes #15600

This PR implements a modal that appears when the check-in button is clicked on the asset's check-in page. The user must click a checkbox before they can check in the asset. This behaviour can be enabled or disabled in the general settings tab. The modal has two text fields. One for a general text message in the modal and one next to the checkbox. The text for these fields can also be defined on the general settings page.

Setting disabled:
image

Setting enabled, with text already entered:
image

New verification modal after clicking check-in on the asset page, the asset cannot be checked in:
image

Verification modal after checking the checkbox, the asset can now be checked in:
image

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Different values have been assigned for both settings, and both are saved correctly.
  • The Checkin process has been tested with the setting enabled and disabled.

Test Configuration:

  • PHP version: 8.4.16
  • MySQL version: 11.8.3-MariaDB
  • Webserver version: Apache/2.4.59 (Debian) & Internal Artisan Web Server
  • OS version: Debian GNU/Linux 13.3 (trixie)

Checklist:

@Glukose1 Glukose1 requested a review from snipe as a code owner February 11, 2026 14:49
@snipe
Copy link
Copy Markdown
Member

snipe commented Feb 11, 2026

I'm not sure we'd want this at a settings level though? Also why couldn't you use the checkbox in the required custom fields on checkin/checkout?

@Glukose1
Copy link
Copy Markdown
Author

The required custom field would work; however, I would need to ensure that every asset model where I want the additional verification has the fieldset assigned. For existing models, this is not a problem, but for newly created models, I see it being one. Especially when multiple people, with varying levels of experience, are using the system. Small things like this can easily be forgotten or overlooked in a hurry.

I personally prefer the simple solution of making it a global setting that does not need to be maintained by the user, as the custom fields would.
If people do not want the verification on every check-in, which I totally understand, they can turn off the setting, hiding the additional textboxes to keep the settings page as clean as possible. Your proposed solution using the custom fields remains available for more granular verification on checkin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants