Extract setup_qemu_static() and add test coverage for QEMU binary copy logic#270
Merged
Extract setup_qemu_static() and add test coverage for QEMU binary copy logic#270
Conversation
…y logic The QEMU binary copy logic was duplicated between execute_chroot_script() in src/custompios and chroot_correct_qemu() in src/common.sh. The inline version in custompios also had a bug: the condition used || instead of &&, making it always true (a tautology). This commit: - Extracts the copy logic into a new setup_qemu_static() function in common.sh, fixing the || to && bug and adding arch-match escape hatches - Fixes the aarch64->armv7l case to copy qemu-arm-static (not qemu-aarch64-static) - Replaces both inline copy blocks with calls to setup_qemu_static() - Adds 24 new test cases covering all host/target/OS combinations for the QEMU binary copy logic Related to PR #261 and issue #262. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The QEMU binary copy logic was duplicated between execute_chroot_script() in src/custompios and chroot_correct_qemu() in src/common.sh. The inline version in custompios also had a bug: the condition used || instead of &&, making it always true (a tautology).
This commit:
Related to PR #261 and issue #262.