Skip to content

HCK-15980: add line normalization for windows #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chulanovskyi-bs merged 2 commits into from
May 6, 2026
Merged

HCK-15980: add line normalization for windows #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01a4383
HCK-15980: add line normalization for windows
ivan-m-dev May 6, 2026
0574c76
Merge branch 'develop' into HCK-15980-windows-empty-line
ivan-m-dev May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions forward_engineering/ddlProvider/ddlHelpers/indexHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const _ = require('lodash');
const { escapeSingleQuote } = require('../../utils/general');
const { escapeSingleQuote, normalizeLineEndings } = require('../../utils/general');

module.exports = ({ prepareName, getNamePrefixedWithSchemaName }) => {
const getIndexType = indexType => {
Expand Down Expand Up @@ -51,9 +51,9 @@ module.exports = ({ prepareName, getNamePrefixedWithSchemaName }) => {
let options = `${loggingClause}${tableSpacePart}${indexCompression}`;

if (index_properties) {
options = ` ${index_properties}`;
options = ` ${normalizeLineEndings(index_properties)}`;
} else if (index_attributes) {
options = ` ${index_attributes}`;
options = ` ${normalizeLineEndings(index_attributes)}`;
}
const isKeysEmpty = _.isEmpty(indxKey) && _.isEmpty(column_expression);

Expand Down
3 changes: 3 additions & 0 deletions forward_engineering/utils/general.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,8 @@ const isParentContainerActivated = collection => {

const getId = entity => entity.id || entity.role.id;

const normalizeLineEndings = str => str.replaceAll('\r\n', '\n');

module.exports = {
getDbName,
getBucketName,
Expand Down Expand Up @@ -265,4 +267,5 @@ module.exports = {
isObjectInDeltaModelActivated,
isParentContainerActivated,
getId,
normalizeLineEndings,
};