chore(deps): Bump helidon from 4.3.4 to 4.4.0 in /pbj-core/hiero-dependency-versions#751
Open
dependabot[bot] wants to merge 4 commits intomainfrom
Open
Conversation
Bumps `helidon` from 4.3.4 to 4.4.0. Updates `io.helidon.webserver:helidon-webserver` from 4.3.4 to 4.4.0 Updates `io.helidon.webserver:helidon-webserver-http2` from 4.3.4 to 4.4.0 Updates `io.helidon.metrics:helidon-metrics-api` from 4.3.4 to 4.4.0 Updates `io.helidon.common.features:helidon-common-features-api` from 4.3.4 to 4.4.0 Updates `io.helidon.common.features:helidon-common-features-processor` from 4.3.4 to 4.4.0 Updates `io.helidon.common.features:helidon-common-features-codegen` from 4.3.4 to 4.4.0 Updates `io.helidon.config.metadata:helidon-config-metadata-codegen` from 4.3.4 to 4.4.0 Updates `io.helidon.config:helidon-config-metadata-processor` from 4.3.4 to 4.4.0 Updates `io.helidon.codegen:helidon-codegen-apt` from 4.3.4 to 4.4.0 Updates `io.helidon.builder:helidon-builder-codegen` from 4.3.4 to 4.4.0 Updates `io.helidon.webserver.observe:helidon-webserver-observe-metrics` from 4.3.4 to 4.4.0 Updates `io.helidon.webclient:helidon-webclient` from 4.3.4 to 4.4.0 Updates `io.helidon.webclient:helidon-webclient-http2` from 4.3.4 to 4.4.0 --- updated-dependencies: - dependency-name: io.helidon.webserver:helidon-webserver dependency-version: 4.4.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: io.helidon.webserver:helidon-webserver-http2 dependency-version: 4.4.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: io.helidon.metrics:helidon-metrics-api dependency-version: 4.4.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: io.helidon.common.features:helidon-common-features-api dependency-version: 4.4.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: io.helidon.common.features:helidon-common-features-processor dependency-version: 4.4.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: io.helidon.common.features:helidon-common-features-codegen dependency-version: 4.4.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: io.helidon.config.metadata:helidon-config-metadata-codegen dependency-version: 4.4.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: io.helidon.config:helidon-config-metadata-processor dependency-version: 4.4.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: io.helidon.codegen:helidon-codegen-apt dependency-version: 4.4.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: io.helidon.builder:helidon-builder-codegen dependency-version: 4.4.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: io.helidon.webserver.observe:helidon-webserver-observe-metrics dependency-version: 4.4.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: io.helidon.webclient:helidon-webclient dependency-version: 4.4.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: io.helidon.webclient:helidon-webclient-http2 dependency-version: 4.4.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
dependabot
bot
added
dependencies
Signed-off-by: Anthony Petrov <anthony@swirldslabs.com>
JUnit Test Report 78 files ±0 78 suites ±0 3m 40s ⏱️ +42s Results for commit c175317. ± Comparison against base commit 6a1438d. This pull request removes 6 and adds 6 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Integration Test Report 415 files ±0 415 suites ±0 20m 17s ⏱️ + 3m 17s Results for commit c175317. ± Comparison against base commit 6a1438d. This pull request removes 3 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
jjohannes
reviewed
Mar 20, 2026
| module("io.micrometer:micrometer-registry-otlp", "micrometer.registry.otlp") | ||
| module("io.opentelemetry.proto:opentelemetry-proto", "io.opentelemetry.proto") | ||
| module("io.prometheus:simpleclient", "simpleclient") { requires("simpleclient.tracer.common") } | ||
| } |
Collaborator
There was a problem hiding this comment.
This works, but I have two suggestions (I'll push a commit for them):
- move the patching to
settings.gradle.ktsso that it applies globally to all modules (consistency, build cache performance) - The
simpleclientdoes not work, because it misses the direct dependency tosimpleclient_tracer_commonin its metadata. It has hard-wired dependencies that usually would bring it in, but remove them here: https://github.com/hiero-ledger/hiero-gradle-conventions/blob/main/src/main/kotlin/org.hiero.gradle.base.jpms-modules.gradle.kts#L17-L21
The more consistent fix is to add the dependency. Then the module patching picks is up correctly.
Follow up:
- Move rules from settings.gradle.kts here into
hiero-gradle-conventions/blob/main/src/main/kotlin/org.hiero.gradle.base.jpms-modules.gradle.ktsUpdate patch rules for micrometer/opentelemetry/prometheus hiero-ledger/hiero-gradle-conventions#444
Signed-off-by: Jendrik Johannes <jendrik@onepiece.software>
jjohannes
reviewed
Mar 20, 2026
| module("io.micrometer:micrometer-registry-otlp", "micrometer.registry.otlp") | ||
| module("io.opentelemetry.proto:opentelemetry-proto", "io.opentelemetry.proto") | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
How this needs to be written is not very nice. We did this a few times now in different repos that requires an patch rule update. I think the underlying plugins should offer a notation for this directly:
jjohannes
previously approved these changes
Mar 20, 2026
Signed-off-by: Jendrik Johannes <jendrik@onepiece.software>
jjohannes
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
helidonfrom 4.3.4 to 4.4.0.Updates
io.helidon.webserver:helidon-webserverfrom 4.3.4 to 4.4.0Updates
io.helidon.webserver:helidon-webserver-http2from 4.3.4 to 4.4.0Updates
io.helidon.metrics:helidon-metrics-apifrom 4.3.4 to 4.4.0Updates
io.helidon.common.features:helidon-common-features-apifrom 4.3.4 to 4.4.0Updates
io.helidon.common.features:helidon-common-features-processorfrom 4.3.4 to 4.4.0Updates
io.helidon.common.features:helidon-common-features-codegenfrom 4.3.4 to 4.4.0Updates
io.helidon.config.metadata:helidon-config-metadata-codegenfrom 4.3.4 to 4.4.0Updates
io.helidon.config:helidon-config-metadata-processorfrom 4.3.4 to 4.4.0Updates
io.helidon.codegen:helidon-codegen-aptfrom 4.3.4 to 4.4.0Updates
io.helidon.builder:helidon-builder-codegenfrom 4.3.4 to 4.4.0Updates
io.helidon.webserver.observe:helidon-webserver-observe-metricsfrom 4.3.4 to 4.4.0Updates
io.helidon.webclient:helidon-webclientfrom 4.3.4 to 4.4.0Updates
io.helidon.webclient:helidon-webclient-http2from 4.3.4 to 4.4.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)