Update vagrant cloud notice to hcp vagrant#13542
Open
im2nguyen wants to merge 2 commits intohashicorp:mainfrom
Open
Update vagrant cloud notice to hcp vagrant#13542im2nguyen wants to merge 2 commits intohashicorp:mainfrom
im2nguyen wants to merge 2 commits intohashicorp:mainfrom
Conversation
📄 Content ChecksUpdated: Fri, 15 Nov 2024 21:53:17 GMT Found 1 error(s)
|
| Position | Description | Rule |
|---|---|---|
3:92-3:157 |
Unexpected fully-qualified link to developer.hashicorp.com: https://developer.hashicorp.com/hcp/docs/vagrant. Replace with a relative path internal to Developer. Possibly: /hcp/docs/vagrant. |
ensure-valid-link-format |
kaitlincart
reviewed
Nov 14, 2024
kaitlincart
reviewed
Nov 14, 2024
|
|
||
| @include 'vagrant-cloud-deprecation.mdx' | ||
|
|
||
| Vagrant Cloud serves a public, searchable index of Vagrant boxes. It's easy to find |
Contributor
There was a problem hiding this comment.
Suggested change
| Vagrant Cloud serves a public, searchable index of Vagrant boxes. It's easy to find | |
| HCP Vagrant Registry serves a public, searchable index of Vagrant boxes. It's easy to find |
All of this content should still apply to the new service.
kaitlincart
reviewed
Nov 14, 2024
|
|
||
| @include 'vagrant-cloud-deprecation.mdx' | ||
|
|
||
| This page will cover creating a new box in Vagrant Cloud and how to distribute |
Contributor
There was a problem hiding this comment.
Suggested change
| This page will cover creating a new box in Vagrant Cloud and how to distribute | |
| This page will cover creating a new box in HCP Vagrant Registry and how to distribute |
kaitlincart
reviewed
Nov 14, 2024
| @include 'vagrant-cloud-deprecation.mdx' | ||
|
|
||
| This page will cover creating a new box in Vagrant Cloud and how to distribute | ||
| it to users. Boxes can be distributed without Vagrant Cloud, but |
Contributor
There was a problem hiding this comment.
Suggested change
| it to users. Boxes can be distributed without Vagrant Cloud, but | |
| it to users. Boxes can be distributed without HCP Vagrant Registry, but |
Co-authored-by: kaitlincart <43049322+kaitlincart@users.noreply.github.com>
Author
|
After talking to Kait, we're not going to update the changes from Vagrant Cloud -> HCP Vagrant Registry until Jan |
tehut
reviewed
Nov 19, 2024
Contributor
tehut
left a comment
There was a problem hiding this comment.
I was hoping to pull your branch and submit it myself to save you the trouble, but I think it's fork. Any chance we could add the notice to the overview pages so it's consistently on the first thing people click on.
| @@ -0,0 +1,5 @@ | |||
| <Note> | |||
|
|
|||
| HashiCorp has moved Vagrant Cloud and migrated the boxes to HCP Vagrant Registry. Read the [documentation](https://developer.hashicorp.com/hcp/docs/vagrant) to learn more about HCP Vagrant Registry. | |||
Contributor
There was a problem hiding this comment.
Just an easy-add suggestion based on the content linter message
Suggested change
| HashiCorp has moved Vagrant Cloud and migrated the boxes to HCP Vagrant Registry. Read the [documentation](https://developer.hashicorp.com/hcp/docs/vagrant) to learn more about HCP Vagrant Registry. | |
| HashiCorp has moved Vagrant Cloud and migrated the boxes to HCP Vagrant Registry. Read the [documentation](/hcp/docs/vagrant) to learn more about HCP Vagrant Registry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.