Provision action trigger ordering with provision action#13690
Open
anshulsharma-hashicorp wants to merge 1 commit intomainfrom
Open
Provision action trigger ordering with provision action#13690anshulsharma-hashicorp wants to merge 1 commit intomainfrom
anshulsharma-hashicorp wants to merge 1 commit intomainfrom
Conversation
chrisroberts
requested changes
Jul 8, 2025
| to perform their operation and call to the next item but in some cases will continue to | ||
| do things once the next item completes. In the Provision action, the next item in the | ||
| stack is executed [here](https://github.com/hashicorp/vagrant/blob/main/lib/vagrant/action/builtin/provision.rb#L82-L83).but the actual provisioning happens at the end [here](https://github.com/hashicorp/vagrant/blob/main/lib/vagrant/action/builtin/provision.rb#L129-L133), after the rest of the stack | ||
| has executed and exited. |
Member
There was a problem hiding this comment.
This needs to be updated for grammar and clarity as it's mixing terms.
The provision action behaves slightly different than other actions. When Vagrant executes its stack, each action performs some function and then calls the next action in the stack. In some cases (like the provision action), the action will perform some function, call the next action, and wait for the it to return to perform some extra functionality or cleanup. This behavior can result in seemingly unexpected results for after triggers since the targeted action will complete after the rest of the actions in the stack have executed.
| info: "INSIDE AFTER machine_action_provision HOOK TRIGGER" | ||
|
|
||
| end | ||
| ``` |
Member
There was a problem hiding this comment.
Output of this should be included to display the behavior.
| ``` | ||
|
|
||
| When running `vagrant provision` or `vagrant up`, the before and after triggers | ||
| will run before the provisioning of the box happens. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.