fix(auth): use REASON_LOGOUT constant instead of string in logout URLs#49
Closed
jcdelepine wants to merge 1 commit intohorde:FRAMEWORK_6_0from
Closed
fix(auth): use REASON_LOGOUT constant instead of string in logout URLs#49jcdelepine wants to merge 1 commit intohorde:FRAMEWORK_6_0from
jcdelepine wants to merge 1 commit intohorde:FRAMEWORK_6_0from
Conversation
Member
|
Hi @jcdelepine Thank you for reporting this. There was some parallel development before I really noticed your message. Can you re-test with this weekend's changes included? They may solve the problem already. If not I will try to incorporate your PR to fix the reported issue with custom / alternate logout pages. We intend to go on supporting custom login/logout pages. |
Contributor
Author
|
Works for me. |
Member
|
Closing as @jcdelepine confirms we have solved this issue through a parallel development. Thank you for reporting though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 98731ee introduced logout_reason=logout (string) in logout URLs,
but login.php compares against Horde_Auth::REASON_LOGOUT (integer 4).
This caused redirect_on_logout to never trigger for installations
that configure an alternate logout page.