Conversation
Add `includeSkills` option to sync configuration, which defaults to true. This allows the `~/.config/opencode/skills/` directory to be synced alongside other configuration files and directories. Updated: - `src/sync/config.ts`: Added `includeSkills` to interfaces and normalization logic. - `src/sync/paths.ts`: Added `skills` directory to sync plan items. - `src/index.ts`: Exposed `includeSkills` in `opencode_sync` tool arguments. - `src/sync/service.ts`: Handled `includeSkills` in init and status commands. - `README.md`: Documented the new option and synced path. - `src/sync/config.test.ts` & `src/sync/paths.test.ts`: Added tests for the new feature. Co-authored-by: iHildy <25069719+iHildy@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Add `includeSkills` option to sync configuration, which defaults to true. This allows the `~/.config/opencode/skills/` directory to be synced alongside other configuration files and directories. Updated: - `src/sync/config.ts`: Added `includeSkills` to interfaces and normalization logic. - `src/sync/paths.ts`: Added `skills` directory to sync plan items. - `src/index.ts`: Exposed `includeSkills` in `opencode_sync` tool arguments. - `src/sync/service.ts`: Handled `includeSkills` in init and status commands. - `README.md`: Documented the new option and synced path. - `src/sync/config.test.ts` & `src/sync/paths.test.ts`: Added tests for the new feature. Co-authored-by: iHildy <25069719+iHildy@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request successfully adds support for syncing the skills directory. The changes are comprehensive, covering configuration, sync logic, command-line arguments, status reporting, and documentation. The new functionality is also backed by unit tests. The implementation is consistent with existing patterns in the codebase. I have one minor suggestion to improve code clarity.
| if (config.includeSkills !== false) { | ||
| items.push({ | ||
| localPath: path.join(configRoot, SKILLS_DIR), | ||
| repoPath: path.join(repoConfigRoot, SKILLS_DIR), | ||
| type: 'dir', | ||
| isSecret: false, | ||
| isConfigFile: false, | ||
| }); | ||
| } |
There was a problem hiding this comment.
The config parameter is of type NormalizedSyncConfig, where includeSkills is a boolean. The check config.includeSkills !== false is therefore equivalent to simply config.includeSkills. Using the simpler form improves readability.
For context, the same pattern is used for includeModelFavorites on line 218, which could also be simplified.
| if (config.includeSkills !== false) { | |
| items.push({ | |
| localPath: path.join(configRoot, SKILLS_DIR), | |
| repoPath: path.join(repoConfigRoot, SKILLS_DIR), | |
| type: 'dir', | |
| isSecret: false, | |
| isConfigFile: false, | |
| }); | |
| } | |
| if (config.includeSkills) { | |
| items.push({ | |
| localPath: path.join(configRoot, SKILLS_DIR), | |
| repoPath: path.join(repoConfigRoot, SKILLS_DIR), | |
| type: 'dir', | |
| isSecret: false, | |
| isConfigFile: false, | |
| }); | |
| } |
🤖 Review Jules RelayI found 1 Gemini suggestion so far. Type |
Add `includeSkills` option to sync configuration, which defaults to true. This allows the `~/.config/opencode/skills/` directory to be synced alongside other configuration files and directories. Updated: - `src/sync/config.ts`: Added `includeSkills` to interfaces and normalization logic. - `src/sync/paths.ts`: Added `skills` directory to sync plan items. - `src/index.ts`: Exposed `includeSkills` in `opencode_sync` tool arguments. - `src/sync/service.ts`: Handled `includeSkills` in init and status commands. - `README.md`: Documented the new option and synced path. - `src/sync/config.test.ts` & `src/sync/paths.test.ts`: Added tests for the new feature. Co-authored-by: iHildy <25069719+iHildy@users.noreply.github.com>
Add `includeSkills` option to sync configuration, which defaults to true. This allows the `~/.config/opencode/skills/` directory to be synced alongside other configuration files and directories. Updated: - `src/sync/config.ts`: Added `includeSkills` to interfaces and normalization logic. - `src/sync/paths.ts`: Added `skills` directory to sync plan items. - `src/index.ts`: Exposed `includeSkills` in `opencode_sync` tool arguments. - `src/sync/service.ts`: Handled `includeSkills` in init and status commands. - `README.md`: Documented the new option and synced path. - `src/sync/config.test.ts` & `src/sync/paths.test.ts`: Added tests for the new feature. Co-authored-by: iHildy <25069719+iHildy@users.noreply.github.com>
Add support for syncing the skills directory in opencode-synced. Added a new
includeSkillsconfiguration flag (defaulting to true) and updated the sync plan to include the~/.config/opencode/skills/directory. Updated the tool arguments, status command, and documentation. Verified with unit tests.Fixes #40
PR created automatically by Jules for task 8083669518881400648 started by @iHildy