Conversation
Preview of modified filesPreview of modified Markdown: |
| ``` bash | ||
| yarn upgrade @ibexa/frontend-config @ibexa/ts-config | ||
| composer require ibexa/headless:v5.0.7 --with-all-dependencies --no-scripts | ||
| composer recipes:install ibexa/headless --force -v |
There was a problem hiding this comment.
due to how flex resolves recipes, and that we forked JMSTranslationBundle this command at first installs recipes for our fork - so it tries to add JMSTranslationBundle to bundles.php which is already there, and then it UNinstall recipes for original repository and that step eventually removes entry from bundles.php. There is no easy way around that, that would not affect fresh installs, so our suggestion at this moment is that after recipes:install you should manually restore
JMS\TranslationBundle\JMSTranslationBundle::class => ['all' => true], in bundles.php in old position
There was a problem hiding this comment.
Thanks, added in eb85427 , could you have a look?
Recipes - love them when they work, hate them when they don't 😓
|
I took the liberty to add https://ibexa.atlassian.net/browse/IBX-11485 to this one, since it basically resolves this issue by adding an additional step. 😉 |
konradoboza
changed the title
mnocon
added
Needs DOC review
Wait with merge
ibexa-workflow-automation-1
bot
requested review from
adriendupuis,
dabrt and
julitafalcondusza
and removed request for
a team
|
@konradoboza I added a section for the "gotcha" of SF 7.4 (var/share dir) in fa5d64d , could you please have a look again? |
|
adriendupuis
left a comment
adriendupuis
left a comment
There was a problem hiding this comment.
Section 2. shouldn't be empty and shouldn't let the reader helpless.
The "official Symfony upgrade instructions" paragraph could be moved up into this section 2.
| 2. To allow installing Symfony 7.4, update the requirements for `symfony` packages in `composer.json` as in the example below: | ||
|
|
||
| ``` diff | ||
| - "symfony/console": "7.3.*", | ||
| + "symfony/console": "7.4.*", | ||
| ``` |
There was a problem hiding this comment.
I would try to emphase on that every package must be updated so reader don't do it only for the console as in the example:
| 2. To allow installing Symfony 7.4, update the requirements for `symfony` packages in `composer.json` as in the example below: | |
| ``` diff | |
| - "symfony/console": "7.3.*", | |
| + "symfony/console": "7.4.*", | |
| ``` | |
| 2. To allow installing Symfony 7.4, update the requirements for **all** `symfony` packages in `composer.json` as in the example below: | |
| ``` diff | |
| - "symfony/<package>": "7.3.*", | |
| + "symfony/<package>": "7.4.*", | |
| ``` |
| + "symfony/console": "7.4.*", | ||
| ``` | ||
|
|
||
| 3. Review your code, configuration, and third-party bundles for Symfony 7.4 compatibility. |
There was a problem hiding this comment.
It seems Rector can't help there, no rule for 7.4 in https://github.com/rectorphp/rector-symfony/tree/main/rules
Maybe we could link to https://github.com/symfony/symfony/blob/7.4/UPGRADE-7.4.md sooner from this section
| For more details about the new version, see the official Symfony [upgrade instructions](https://github.com/symfony/symfony/blob/7.4/UPGRADE-7.4.md) and [blog posts introducing this release](https://symfony.com/blog/category/living-on-the-edge/8.0-7.4). | ||
| Among the changes are: |
There was a problem hiding this comment.
Merge within section "2. Review your code,…"
4 participants
Target: Link change is for 5.0 only, but update instructions are 4.6 and 5.0
Adding update instructions for Symfony 7.4
Status: needs to be merged together with the 5.0.7 release.
JIRA: https://ibexa.atlassian.net/browse/IBX-11485