Skip to content

[patch] Prevent helm error when optional ibm_cis_cert_manager values are absent #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tomklapiscak wants to merge 4 commits into from
Closed

[patch] Prevent helm error when optional ibm_cis_cert_manager values are absent #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7db17be
[patch] Prevent helm error when optional ibm_cis_cert_manager values …
tomklapiscak Mar 27, 2026
7f26a80
trigger sync to mas-gitops
tomklapiscak Mar 27, 2026
b189e13
also fix main dro app
tomklapiscak Mar 27, 2026
00c2415
make dro-tls-secret mount optional since it may not be present
tomklapiscak Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,3 @@ Documentation
[https://ibm-mas.github.io/gitops/](https://ibm-mas.github.io/gitops/)

[https://github.com/ibm-mas/gitops-demo/tree/002](https://github.com/ibm-mas/gitops-demo/tree/002)

2 changes: 1 addition & 1 deletion cluster-applications/030-ibm-dro/templates/08-postsync-update-sm_Job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ spec:
secret:
secretName: dro-tls-secret
defaultMode: 420
optional: false
optional: true
backoffLimit: 4
{{- end }}

Expand Down
2 changes: 2 additions & 0 deletions root-applications/ibm-mas-cluster-root/templates/030-ibm-dro-app.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,11 @@ spec:
dro_cmm_setup: "{{ .Values.ibm_dro.dro_cmm_setup }}"
dro_install_plan: "{{ .Values.ibm_dro.dro_install_plan }}"
dro_public_domain: "{{ .Values.ibm_dro.dro_public_domain }}"
{{- if not (empty .Values.ibm_cis_cert_manager) }}
dns_provider: "{{ .Values.ibm_cis_cert_manager.dns_provider }}"
ocp_cluster_domain: "{{ .Values.ibm_cis_cert_manager.ocp_cluster_domain }}"
cis_apikey: "{{ .Values.ibm_cis_cert_manager.cis_apikey }}"
{{- end }}
cis_crn: "{{ .Values.ibm_dro.cis_crn }}"
imo_install_plan: "{{ .Values.ibm_dro.imo_install_plan }}"
cli_image_repo: {{ .Values.cli_image_repo }}
Expand Down
5 changes: 5 additions & 0 deletions root-applications/ibm-mas-cluster-root/templates/031-ibm-dro-public.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
{{- if not (empty .Values.ibm_dro) }}

# Prevent "<.Values.ibm_cis_cert_manager.dns_provider>: nil pointer evaluating interface {}.dns_provider" error when (optional) ibm_cis_cert_manager values are absent
{{- if not (empty .Values.ibm_cis_cert_manager) }}

---
# IBM Maximo Operator Catalog
apiVersion: argoproj.io/v1alpha1
Expand Down Expand Up @@ -70,4 +74,5 @@ spec:
- CreateNamespace=false
- RespectIgnoreDifferences=true
- Validate=false
{{- end }}
{{- end }}
Loading