feat(proxy): add --insecure flag to skip upstream TLS verification#99
Open
outofcoffee wants to merge 1 commit intomainfrom
Open
feat(proxy): add --insecure flag to skip upstream TLS verification#99outofcoffee wants to merge 1 commit intomainfrom
outofcoffee wants to merge 1 commit intomainfrom
Conversation
outofcoffee
force-pushed
the
feat/proxy-insecure
branch
from
1bf8c5c to
be4bd06
Compare
outofcoffee
force-pushed
the
feat/proxy-insecure
branch
from
be4bd06 to
b5786e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--insecureflag toimposter proxyfor upstreams that serve a self-signed or otherwise untrusted TLS certificate.Handle→forwardand selects between two cachedhttp.Transportinstances (one verified, one withInsecureSkipVerify), so default behaviour is unchanged when the flag is absent.Motivation
Split out of the
--insecureportion of #82 so it can be reviewed and merged independently of the SOAP-aware proxy work.