Skip to content

Add --no-install-recommends to apt-get install in Dockerfile.olbase#12047

Closed
Skyee90 wants to merge 1 commit intointernetarchive:masterfrom
Skyee90:patch-1
Closed

Add --no-install-recommends to apt-get install in Dockerfile.olbase#12047
Skyee90 wants to merge 1 commit intointernetarchive:masterfrom
Skyee90:patch-1

Conversation

@Skyee90
Copy link
Copy Markdown

@Skyee90 Skyee90 commented Mar 8, 2026

Adds --no-install-recommends flag to the apt-get install command in docker/Dockerfile.olbase (line 17) . This reduces the image layer size by ~100MB based on previous testing, without breaking any functionality. Happy to help.

Adds --no-install-recommends flag to the apt-get install command in 
docker/Dockerfile.olbase (line 17) . This reduces the image layer size by ~100MB based on 
previous testing, without breaking any functionality. 
Happy to help.
Copilot AI review requested due to automatic review settings March 8, 2026 17:26
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the --no-install-recommends flag to the apt-get install command in docker/Dockerfile.olbase, reducing the Docker image layer size by ~100MB by skipping non-essential recommended packages. This aligns with the existing convention already used in scripts/install_nginx.sh.

Changes:

  • Added --no-install-recommends flag to the main apt-get install command in the base Dockerfile to minimize image size.

@jimchamp
Copy link
Copy Markdown
Collaborator

jimchamp commented Mar 9, 2026

Marked as "Can it be closed?" for the following reasons:

  1. PR does not address an open issue.
  2. PR template was not used.

@Skyee90
Copy link
Copy Markdown
Author

Skyee90 commented Mar 9, 2026

@jimchamp the issue was actually open but assigned to someone else but when I noticed i already made the pr

@Skyee90
Copy link
Copy Markdown
Author

Skyee90 commented Mar 9, 2026

Idk i think let it stay maybe the author will accept it.

@github-actions github-actions Bot added the Needs: Response Issues which require feedback from lead label Mar 10, 2026
@mekarpeles
Copy link
Copy Markdown
Member

I see 3 different PRs, I am not confident they are tested, no issue is referenced, PR templated not followed; I am not going to endorse staff time on this one, though appreciate the energy to contribute

@mekarpeles mekarpeles closed this Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Can it be closed? Needs: Response Issues which require feedback from lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants