Add --no-install-recommends to apt-get install in setup_olserver.sh#12049
Closed
Skyee90 wants to merge 1 commit intointernetarchive:masterfrom
Closed
Add --no-install-recommends to apt-get install in setup_olserver.sh#12049Skyee90 wants to merge 1 commit intointernetarchive:masterfrom
Skyee90 wants to merge 1 commit intointernetarchive:masterfrom
Conversation
Adds --no-install-recommends flag to the apt-get install commands in scripts/setup_olserver.sh (lines 26, 34, and 47). This avoids pulling in unnecessary recommended packages during server provisioning, keeping the setup cleaner. Happy to help.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the server provisioning script to avoid installing APT “recommended” packages during Docker setup, helping keep the base system leaner.
Changes:
- Add
--no-install-recommendsto Docker-relatedapt-get installcommands inscripts/setup_olserver.sh.
| # Add Docker's official GPG key: | ||
| sudo apt-get update | ||
| sudo apt-get install ca-certificates curl | ||
| sudo apt-get install --no-install-rcommends ca-certificates curl |
There was a problem hiding this comment.
apt-get option is misspelled as --no-install-rcommends, which will cause the command to fail. Use the correct flag --no-install-recommends (matching the other install commands).
Suggested change
| sudo apt-get install --no-install-rcommends ca-certificates curl | |
| sudo apt-get install --no-install-recommends ca-certificates curl |
Collaborator
|
Marked as "Can it be closed?" for the following reasons:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds --no-install-recommends flag to the apt-get install commands in scripts/setup_olserver.sh (lines 26, 34, and 47). This avoids pulling in unnecessary recommended packages during server provisioning, keeping the setup cleaner.
Happy to help.