Open
Conversation
bdeboe
reviewed
Dec 2, 2020
Collaborator
bdeboe
left a comment
bdeboe
left a comment
There was a problem hiding this comment.
Thanks for contributing!
| <Default Name="restapp" Value="/rest-test" /> | ||
|
|
||
| <Namespace Name="${Namespace}" Code="${Namespace}" Data="${Namespace}" Create="yes" Ensemble="no"> | ||
| <Namespace Name="${Namespace}" Code="${Namespace}" Data="${Namespace}" Create="yes" Ensemble="1"> |
Collaborator
There was a problem hiding this comment.
It's a minor nit, but I'd not add the pile of mappings for interoperability if we don't have to.
Author
There was a problem hiding this comment.
You are right, but but I don't know if we need Ensemble for analytics, if so, I can uncheck this.
And when I have time, we can clean this installer, we don't need and co.
Collaborator
There was a problem hiding this comment.
I'm not sure we need the whole %Installer in the first place (having zpm as a more lightweight solution), but it's sort of part of the template for sizeable samples. By any means, Ensemble is not required for analytics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix docker build
Update zpm
Don't forget to update version on openexchange, version 1.0.0 is not loading samples