POC for an extended record_tags.move#223
Merged
chrisgitiota merged 3 commits intofeat/record-tagsfrom Mar 19, 2026
Merged
Conversation
Contributor
chrisgitiota
commented
Mar 19, 2026
chrisgitiota
commented
itsyaasir
reviewed
Mar 19, 2026
| /// to track how many records and roles are currently using each tag. | ||
| /// Usage counts for roles and tags are summed and build a combined usage count. | ||
| public struct TagRegistry has copy, drop, store { | ||
| tag_map: VecMap<String, u64>, |
Contributor
There was a problem hiding this comment.
Doesn't it make more sense to call it registry here ?
Contributor
Author
There was a problem hiding this comment.
I agree that the field name tag_map is not optimal.
As the field is only used internally IMO a technical and self explanatory name would be good. That said, I would prefer tag_map over registry because registry is very generic.
BUT: There might be better names than tag_map . Already thought about tags but we have this field name already in the RoleTags
How about using tag_map for now and renaming it later on?
itsyaasir
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.