Open
Conversation
github-actions
bot
added
In progress
danlla
requested changes
Apr 8, 2026
Comment on lines
+29
to
+39
| foreach (var s in services) | ||
| { | ||
|
|
||
| var key = s.DownstreamPort.ToString(); | ||
| var weight = weights.TryGetValue(key, out var w) ? w : 1; | ||
|
|
||
| for (var i = 0; i < weight; i++) | ||
| { | ||
| _expandedList.Add(s); | ||
| } | ||
| } |
There was a problem hiding this comment.
Лучше алгоритмически вычислять какой сервис нужно использовать, в таком варианте если веса у сервисов будут большие, то получится огромный список
| using Ocelot.Values; | ||
|
|
||
| var builder = WebApplication.CreateBuilder(args); | ||
|
|
There was a problem hiding this comment.
Не хватает builder.AddServiceDefaults();
Comment on lines
+18
to
+26
| builder.Services.AddCors(options => | ||
| { | ||
| options.AddPolicy("wasm", policy => | ||
| { | ||
| policy.WithOrigins("https://localhost:7282") | ||
| .AllowAnyMethod() | ||
| .AllowAnyHeader(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Во 2 лабе cors нужно перенести из ApiService в ApiGateway, так как клиент теперь взаимодействует с ним
Также по-хорошему брать сами origins из appsettings.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ФИО: Дубова Ксения
Номер группы: 6511
Номер лабораторной: 2
Номер варианта: 5
Краткое описание предметной области: Сотрудник компании
Краткое описание добавленных фич: Добавлены генераторы и балансировка Weighted Round Robin (генератор1 - 1, генератор2 - 2, генератор3 - 1)