fix: fallback to undiciFetch when globalThis.fetch is unavailable#840
Open
deep-innovator wants to merge 1 commit intojackwener:mainfrom
Open
fix: fallback to undiciFetch when globalThis.fetch is unavailable#840deep-innovator wants to merge 1 commit intojackwener:mainfrom
deep-innovator wants to merge 1 commit intojackwener:mainfrom
Conversation
Resolves compatibility issue on Windows with older Node.js versions where `globalThis.fetch` is not available at module load time. This change keeps the original `nativeFetch` function signature unchanged, preserving the no-proxy path behavior while adding a synchronous fallback to `undiciFetch`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows with older Node.js versions,
globalThis.fetchis not available at module load time, causing the originalnativeFetchdefinition to fail immediately.Solution
nativeFetchas a direct request function, preserving the original signature(input, init) => Promise<Response>.undiciFetchsynchronously whenglobalThis.fetchis unavailable.Verification
return nativeFetch(input, init).fetchand theundiciFetchfallback.