[New] forbid-dom-props: Add disallowedValues option for forbidden props#3877
Open
makxca wants to merge 1 commit intojsx-eslint:masterfrom
Open
[New] forbid-dom-props: Add disallowedValues option for forbidden props#3877makxca wants to merge 1 commit intojsx-eslint:masterfrom
disallowedValues option for forbidden props#3877makxca wants to merge 1 commit intojsx-eslint:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3877 +/- ##
==========================================
+ Coverage 97.64% 97.66% +0.02%
==========================================
Files 133 136 +3
Lines 9966 9986 +20
Branches 3703 3706 +3
==========================================
+ Hits 9731 9753 +22
+ Misses 235 233 -2 ☔ View full report in Codecov by Sentry. |
makxca
commented
Jan 11, 2025
ljharb
requested changes
Jan 12, 2025
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Using a regex is a nonstarter; see #3876 (comment)
ljharb
reviewed
Jan 12, 2025
makxca
force-pushed
the
master
branch
2 times, most recently
from
a7911e2 to
d52c0f1
Compare
makxca
force-pushed
the
master
branch
2 times, most recently
from
de2e1ea to
5d3d27c
Compare
makxca
changed the title
valueRegex option for forbidden propsdisallowedValues option for forbidden props
Author
|
I changed |
Author
|
@ljharb, hello! Opensource is practically new to me. Could you please guide me on this PR's flow? When can it be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
disallowedValuesfor disallowing only certain values for certain propsDiscussion: #3876