feat: replace sandboxes-api with editor-service sessions API#88
Open
feat: replace sandboxes-api with editor-service sessions API#88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/keboola/issue/AJDA-1942
Description
Replaces all usages of the sandboxes-api PHP client with the editor-service sessions API, as the sandboxes API is being turned off. Introduces a lightweight
EditorServiceClientbased on Symfony HTTP client to list sessions, and removes the now-obsoleteDeleteProjectSandboxescommand.Release Notes
Change Type
Refactoring / internal improvement — migrates from sandboxes-api to editor-service sessions API.
Justification
The sandboxes API is being turned off. All commands that listed or deleted sandboxes must use the editor-service sessions API instead, matching sessions by
workspaceSchemaoruserId, and deleting by removing the associated configuration (twice, to purge from trash).Plans for Customer Communication
No customer-facing changes; these are internal maintenance CLI commands.
Impact Analysis
Low risk. Affects three commands (
DeleteOwnerlessWorkspaces,DeleteOrganizationOwnerlessWorkspaces,MassDeleteProjectWorkspaces) and removes one (DeleteProjectSandboxes). No breaking changes to command interfaces.Deployment Plan
Standard CI/CD continuous deployment across all stacks.
Rollback Plan
Standard git revert if issues detected post-deployment.
Post-Release Support Plan
No follow-up actions needed.