fix: Misc issues on keyboards details/install pages 🗺️#679
Merged
darcywong00 merged 11 commits intomasterfrom Mar 17, 2026
Merged
fix: Misc issues on keyboards details/install pages 🗺️#679darcywong00 merged 11 commits intomasterfrom
darcywong00 merged 11 commits intomasterfrom
Conversation
User Test ResultsTest specification and instructions User tests are not required |
darcywong00
changed the title
fix: Set heading line-heights to accommodate Khmer subscripts 🗺️
darcywong00
commented
Mar 13, 2026
| <input id="search-q" type="text" placeholder="<?= $_m_KeyboardDetails("new_keyboard_search") ?>" name="q"> | ||
| <input id='search-page' type='hidden' name='page'> | ||
| <input id="search-f" type="image" src="<?= cdn('img/search-button.png') ?>" value="<?= $_m_KeyboardDetails("search") ?>"> | ||
| <input id="search-f" type="button" value="<?= $_m_KeyboardDetails("search") ?>"> |
Contributor
Author
There was a problem hiding this comment.
Since @ermshiperete has included devin.ai suggestions, I gave it a try and it reported this bug:
Search button changed from type="image" to type="button" without submit handler, breaking form submission
I think changing to "submit" will work.
Member
Those images show that we need to add more padding on the buttons -- currently the text almost overlaps the icon. |
Contributor
Author
Ok - here's with more left/right padding Spanish German Khmer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #677 for #384
Fixes undeclared
$_mon keyboards install lageFixes the following issues on the keyboards details page:
Screenshots
Current live (truncated)
Spanish
Khmer
<h2>Khmer text needs more spacing (line-height?) - TODO for a separate PRWith Adjusted Styling
Spanish
Khmer
CSS subject to more tweakingTest-bot: skip