Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughCompute and reuse a single resolved error log in AbstractKafkaService.handlerError and update errorReporter context to include the resolved error; bump Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/kafka/lib/AbstractKafkaService.ts`:
- Line 134: The current spread `context: { ...context, error:
resolvedErrorLog.error }` in AbstractKafkaService always overwrites any
caller-provided context.error; change it to preserve an existing error by using
a conditional merge (e.g., set error to context.error if present, otherwise
resolvedErrorLog.error) so you don't clobber upstream metadata — update the
expression used where the context is constructed in AbstractKafkaService to
`error: context.error ?? resolvedErrorLog.error` (or equivalent conditional
logic).
In `@packages/kafka/package.json`:
- Line 56: Update the dependency version for "@platformatic/kafka" in the
load-tests package.json so it matches the main package: change the pinned
version "1.28.0" (in the load-tests package.json's dependencies) to "^1.30.0" to
keep both packages using the same "@platformatic/kafka" release.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e8257fa7-b3b9-4a77-998a-0c14c0788a04
📒 Files selected for processing (2)
packages/kafka/lib/AbstractKafkaService.tspackages/kafka/package.json
We’ve recently noticed that Platformatic
AggregatedErrorsare not being properly displayed in Bugsnag. At the moment, we only see the aggregated error message (e.g., “fetch failed 7 times”), which isn’t very helpful for identifying the root cause.The full error details are available in the logs, but it would be much more useful to have them in Bugsnag. This would save us from switching tools and manually searching through logs to investigate issues.
Summary by CodeRabbit
Refactor
Chores