Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Kaui 3.04 UI behavior across refunds, global search hints, tenant settings wording, account table column customization, and bundles page performance to address several reported UX and reliability issues.
Changes:
- Allow decimal refund amounts by loosening the refund amount input step constraint.
- Improve Accounts table “edit columns / column ordering” behavior by syncing dropdown state with DataTables state changes.
- Add “bundle:” as a suggested search query, rename the tenant access button label, and avoid loading the full catalog on the bundles index page.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| app/views/kaui/refunds/_form.html.erb | Allows decimal input for refund amounts via step="any". |
| app/views/kaui/components/search_input/_search_input.html.erb | Adds bundle: to suggested search query badges. |
| app/views/kaui/admin_tenants/show.html.erb | Renames the button label to “Allow Tenant Access”. |
| app/views/kaui/accounts/_multi_functions_bar.html.erb | Reworks DataTables column visibility/reorder dropdown syncing and persistence. |
| app/views/kaui/accounts/_functions_bar.html.erb | Same as above for the non-multi functions bar variant. |
| app/controllers/kaui/bundles_controller.rb | Avoids loading the full catalog in bundles index to prevent memory issues. |
Comments suppressed due to low confidence (1)
app/views/kaui/accounts/_multi_functions_bar.html.erb:369
- The code builds checkboxes with
data-column: colIdx(from the savedColReorderstate), but then callsresetDataColumn()which overwritesdata-columnto sequential indices. Since the change handler usestable.column($(...).attr('data-column')), this renumbering can cause checkboxes to toggle the wrong column when a saved reorder exists.
Suggestion: keep data-column as the stable DataTables column index (colIdx) and don’t rewrite it (or store the sequential position in a separate attribute).
var $checkbox = $("<input>", {
type: "checkbox",
value: colIdx,
checked: isVisible,
"data-column": colIdx,
class: "column-toggle"
});
$label.append($checkbox).append(" " + col_name);
var $icon = $("<span>", { class: "glyphicon glyphicon-option-vertical icon-drag"});
$label.append($icon);
$item.append($label);
$list.append($item);
}
}
resetDataColumn();
resetDataId();
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This reverts commit 0024f59.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues: