Skip to content

Kaui 3.04#584

Merged
tungleduyxyz merged 7 commits intomasterfrom
kaui_3.04
Mar 6, 2026
Merged

Kaui 3.04#584
tungleduyxyz merged 7 commits intomasterfrom
kaui_3.04

Conversation

@tungleduyxyz
Copy link
Contributor

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Kaui 3.04 UI behavior across refunds, global search hints, tenant settings wording, account table column customization, and bundles page performance to address several reported UX and reliability issues.

Changes:

  • Allow decimal refund amounts by loosening the refund amount input step constraint.
  • Improve Accounts table “edit columns / column ordering” behavior by syncing dropdown state with DataTables state changes.
  • Add “bundle:” as a suggested search query, rename the tenant access button label, and avoid loading the full catalog on the bundles index page.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
app/views/kaui/refunds/_form.html.erb Allows decimal input for refund amounts via step="any".
app/views/kaui/components/search_input/_search_input.html.erb Adds bundle: to suggested search query badges.
app/views/kaui/admin_tenants/show.html.erb Renames the button label to “Allow Tenant Access”.
app/views/kaui/accounts/_multi_functions_bar.html.erb Reworks DataTables column visibility/reorder dropdown syncing and persistence.
app/views/kaui/accounts/_functions_bar.html.erb Same as above for the non-multi functions bar variant.
app/controllers/kaui/bundles_controller.rb Avoids loading the full catalog in bundles index to prevent memory issues.
Comments suppressed due to low confidence (1)

app/views/kaui/accounts/_multi_functions_bar.html.erb:369

  • The code builds checkboxes with data-column: colIdx (from the saved ColReorder state), but then calls resetDataColumn() which overwrites data-column to sequential indices. Since the change handler uses table.column($(...).attr('data-column')), this renumbering can cause checkboxes to toggle the wrong column when a saved reorder exists.

Suggestion: keep data-column as the stable DataTables column index (colIdx) and don’t rewrite it (or store the sequential position in a separate attribute).

        var $checkbox = $("<input>", {
          type: "checkbox",
          value: colIdx,
          checked: isVisible,
          "data-column": colIdx,
          class: "column-toggle"
        });
        $label.append($checkbox).append(" " + col_name);
        var $icon = $("<span>", { class: "glyphicon glyphicon-option-vertical icon-drag"});
        $label.append($icon);
        $item.append($label);
        $list.append($item);
      }
    }
    resetDataColumn();
    resetDataId();
  }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tungleduyxyz tungleduyxyz marked this pull request as ready for review March 6, 2026 02:25
@tungleduyxyz tungleduyxyz merged commit e2e03b9 into master Mar 6, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants