Set sidecar.istio.io/inject as label instead of annotation

[folliehiyuki]

Description

It seems the fix was made for the other Knative-related repos, but not this one.

Changes

• Set sidecar.istio.io/inject=true as Label instead of Annotation
• Also fix TestDeleteProfileFlag test case since it should reference the test profile defined within the function instead of the annotation from Istio profile

Reference

Fixes #1969

https://istio.io/latest/docs/reference/config/annotations/#SidecarInject

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: folliehiyuki / name: Hoang Nguyen (84a5510)

[knative-prow]

Welcome @folliehiyuki! It looks like this is your first PR to knative/client 🎉

[knative-prow]

Hi @folliehiyuki. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dprotaso]

/lgtm
/approve

[dprotaso]

You'll have to sign the CLA and fix the build issues the PR introduces

[folliehiyuki]

/retest

[knative-prow]

@folliehiyuki: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[folliehiyuki]

I ran ./hack/build.sh -c to regenerate the docs.

[dprotaso]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, folliehiyuki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dprotaso]

Thanks for the changes!

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.88%. Comparing base (443be36) to head (84a5510).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2142   +/-   ##
=======================================
  Coverage   71.88%   71.88%           
=======================================
  Files         233      233           
  Lines       13533    13535    +2     
=======================================
+ Hits         9728     9730    +2     
  Misses       2999     2999           
  Partials      806      806           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.