Fix KUBERNETES_MIN_VERSION propagation to operand workloads#2245
Fix KUBERNETES_MIN_VERSION propagation to operand workloads#2245eXist-FraGGer wants to merge 1 commit intoknative:mainfrom
Conversation
|
|
|
Welcome @eXist-FraGGer! It looks like this is your first PR to knative/operator 🎉 |
|
Hi @eXist-FraGGer. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
@eXist-FraGGer: 0 warnings.
Details
In response to this:
Fixes #2233
Proposed Changes
- Add a common reconciler transformer that propagates
KUBERNETES_MIN_VERSIONfrom operator env to managed workloads.- Inject/override
KUBERNETES_MIN_VERSIONfor containers and initContainers inDeployment,StatefulSet,DaemonSet, andJobresources.- Wire the transformer into the shared transform pipeline and add unit tests for both injection and no-op behavior when the env var is unset.
Release Note
Fixes a regression where `KUBERNETES_MIN_VERSION` configured for the operator was not propagated to Knative Serving/Eventing workloads managed by the operator.Verification
go test ./pkg/reconciler/common -count=1passed.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: eXist-FraGGer The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Fixes #2233
Proposed Changes
KUBERNETES_MIN_VERSIONfrom operator env to managed workloads.KUBERNETES_MIN_VERSIONfor containers and initContainers inDeployment,StatefulSet,DaemonSet, andJobresources.Release Note
Verification
go test ./pkg/reconciler/common -count=1passed.