Skip to content

Fix KUBERNETES_MIN_VERSION propagation to operand workloads#2245

Open
eXist-FraGGer wants to merge 1 commit intoknative:mainfrom
eXist-FraGGer:main
Open

Fix KUBERNETES_MIN_VERSION propagation to operand workloads#2245
eXist-FraGGer wants to merge 1 commit intoknative:mainfrom
eXist-FraGGer:main

Conversation

@eXist-FraGGer
Copy link

Fixes #2233

Proposed Changes

  • Add a common reconciler transformer that propagates KUBERNETES_MIN_VERSION from operator env to managed workloads.
  • Inject/override KUBERNETES_MIN_VERSION for containers and initContainers in Deployment, StatefulSet, DaemonSet, and Job resources.
  • Wire the transformer into the shared transform pipeline and add unit tests for both injection and no-op behavior when the env var is unset.

Release Note

Fixes a regression where `KUBERNETES_MIN_VERSION` configured for the operator was not propagated to Knative Serving/Eventing workloads managed by the operator.

Verification

  • go test ./pkg/reconciler/common -count=1 passed.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 28, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: eXist-FraGGer / name: Ivan Sarokin (389f5a2)

@knative-prow
Copy link

knative-prow bot commented Feb 28, 2026

Welcome @eXist-FraGGer! It looks like this is your first PR to knative/operator 🎉

@knative-prow
Copy link

knative-prow bot commented Feb 28, 2026

Hi @eXist-FraGGer. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 28, 2026
@knative-prow knative-prow bot requested review from aliok and houshengbo February 28, 2026 00:20
Copy link

@knative-prow knative-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eXist-FraGGer: 0 warnings.

Details

In response to this:

Fixes #2233

Proposed Changes

  • Add a common reconciler transformer that propagates KUBERNETES_MIN_VERSION from operator env to managed workloads.
  • Inject/override KUBERNETES_MIN_VERSION for containers and initContainers in Deployment, StatefulSet, DaemonSet, and Job resources.
  • Wire the transformer into the shared transform pipeline and add unit tests for both injection and no-op behavior when the env var is unset.

Release Note

Fixes a regression where `KUBERNETES_MIN_VERSION` configured for the operator was not propagated to Knative Serving/Eventing workloads managed by the operator.

Verification

  • go test ./pkg/reconciler/common -count=1 passed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow
Copy link

knative-prow bot commented Feb 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eXist-FraGGer
Once this PR has been reviewed and has the lgtm label, please assign matzew for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken KUBERNETES_MIN_VERSION

1 participant