Skip to content

test: refactor to modules and accessible locators. #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knightedcodemonkey merged 2 commits into from
Mar 28, 2026
+2,140 −1,976
Merged

test: refactor to modules and accessible locators. #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc7bf83
test: refactor to modules and accessible locators.
knightedcodemonkey Mar 28, 2026
996e403
refactor: address comments.
knightedcodemonkey Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"nursery": "off"
},
"rules": {
"eqeqeq": "error",
"no-console": "error",
"no-unused-vars": "error",
"no-shadow": "error",
Expand Down
4 changes: 4 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ Repository structure:
- Do not introduce bundler-only assumptions into src/ runtime code.
- Prefer async/await over promise chains.
- Do not use IIFE, find another pattern instead.
- In Playwright tests, prefer accessible selectors first: `getByRole`, `getByLabel`, `getByText`, and explicit accessible names.
- Avoid `locator()` for interactive controls when a semantic selector is available.
- Use `locator()` only as a fallback for cases without reliable semantics (for example: document root `html`, structural class assertions, or implementation-only hooks).
- When testability needs improvement, prefer adding accessibility semantics (`role`, `aria-label`, `aria-labelledby`) over introducing new id-only selectors.

## CDN and runtime expectations

Expand Down
Loading
Loading