Replace gcr.io container image references with ghcr.io#4428
Open
aravindtga wants to merge 2 commits intokptdev:mainfrom
Open
Replace gcr.io container image references with ghcr.io#4428aravindtga wants to merge 2 commits intokptdev:mainfrom
aravindtga wants to merge 2 commits intokptdev:mainfrom
Conversation
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
liamfallon
approved these changes
Mar 10, 2026
aravindtga
force-pushed
the
replace-missing-gcr-to-ghcr
branch
from
0e1924f to
e731212
Compare
Signed-off-by: aravind.est <aravindhan.a@est.tech>
aravindtga
force-pushed
the
replace-missing-gcr-to-ghcr
branch
2 times, most recently
from
dd2ee6d to
620ebff
Compare
aravindtga
requested review from
efiacor,
kispaljr and
mozesl-nokia
as code owners
dosubot
bot
added
size:L
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates container image references from gcr.io to ghcr.io across docs and test fixtures, and updates WASM-related e2e coverage and runtime compatibility for Go 1.21+.
Changes:
- Replace
gcr.ioimage references withghcr.ioin documentation, unit tests, and YAML testdata. - Add/adjust WASM e2e testdata to use
ghcr.io/kptdev/krm-functions-catalog/wasm/*images and set the WASM runtime tonodejswhere expected. - Update the embedded NodeJS WASM glue code to use Go’s newer WASM import module name (
gojs) and setKPT_FN_WASM_RUNTIME=nodejsin CI.
Reviewed changes
Copilot reviewed 32 out of 34 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| thirdparty/kyaml/runfn/test/testdata/java/java-deployment.resource.yaml | Update example deployment image reference to ghcr.io. |
| thirdparty/kyaml/runfn/runfn_test.go | Update test image references to ghcr.io. |
| thirdparty/cmdconfig/commands/cmdtree/cmdtree_test.go | Update embedded YAML image references to ghcr.io. |
| thirdparty/cmdconfig/commands/cmdsource/cmdsource_test.go | Update embedded YAML/JSON image references to ghcr.io. |
| thirdparty/cmdconfig/commands/cmdsink/cmdsink_test.go | Update embedded YAML image references to ghcr.io. |
| internal/testutil/testdata/updateMergeConflict/mysql/mysql-statefulset.resource.yaml | Update test fixture image references to ghcr.io. |
| internal/testutil/testdata/updateMergeConflict/java/java-deployment.resource.yaml | Update test fixture image reference to ghcr.io. |
| internal/testutil/testdata/datasetmerged/mysql/mysql-statefulset.resource.yaml | Update test fixture image references to ghcr.io. |
| internal/testutil/testdata/datasetmerged/java/java-deployment.resource.yaml | Update test fixture image reference to ghcr.io. |
| internal/testutil/testdata/dataset6/mysql/mysql-statefulset.resource.yaml | Update test fixture image references to ghcr.io. |
| internal/testutil/testdata/dataset6/java/java-deployment.resource.yaml | Update test fixture image reference to ghcr.io. |
| internal/testutil/testdata/dataset5/mysql/mysql-statefulset.resource.yaml | Update test fixture image references to ghcr.io. |
| internal/testutil/testdata/dataset5/java/java-deployment.resource.yaml | Update test fixture image reference to ghcr.io. |
| internal/testutil/testdata/dataset4/mysql/mysql-statefulset.resource.yaml | Update test fixture image references to ghcr.io. |
| internal/testutil/testdata/dataset4/java/java-deployment.resource.yaml | Update test fixture image reference to ghcr.io. |
| internal/testutil/testdata/dataset3/mysql/mysql-statefulset.resource.yaml | Update test fixture image references to ghcr.io. |
| internal/testutil/testdata/dataset3/java/java-deployment.resource.yaml | Update test fixture image reference to ghcr.io. |
| internal/testutil/testdata/dataset2/mysql/mysql-statefulset.resource.yaml | Update test fixture image references to ghcr.io. |
| internal/testutil/testdata/dataset2/java/java-deployment.resource.yaml | Update test fixture image reference to ghcr.io. |
| internal/testutil/testdata/dataset1/mysql/mysql-statefulset.resource.yaml | Update test fixture image references to ghcr.io. |
| internal/testutil/testdata/dataset1/java/java-deployment.resource.yaml | Update test fixture image reference to ghcr.io. |
| internal/fnruntime/jsglue.go | Adjust embedded WASM JS glue import module name for Go 1.21+. |
| internal/docs/generated/wasmdocs/docs.go | Update WASM push/pull examples to ghcr.io. |
| internal/docs/generated/fndocs/docs.go | Update fn examples to ghcr.io and refresh generated render docs content. |
| e2e/testdata/fn-render/basicpipeline-wasm/Kptfile | Point WASM pipeline to new ghcr.io/.../wasm/* images. |
| e2e/testdata/fn-render/basicpipeline-wasm/.expected/setup.sh | Set expected WASM runtime to nodejs. |
| e2e/testdata/fn-render/basicpipeline-wasm/.expected/diff.patch | Update expected render diff output for the WASM pipeline case. |
| e2e/testdata/fn-eval/wasm-function/.expected/config.yaml | Update eval test to use the new ghcr.io WASM image. |
| documentation/content/en/reference/cli/fn/source/_index.md | Update docs example image reference to ghcr.io. |
| documentation/content/en/reference/cli/fn/sink/_index.md | Update docs example image reference to ghcr.io. |
| documentation/content/en/reference/cli/fn/eval/_index.md | Update docs examples to ghcr.io. |
| documentation/content/en/reference/cli/alpha/wasm/push/_index.md | Update docs example image reference to ghcr.io. |
| documentation/content/en/reference/cli/alpha/wasm/pull/_index.md | Update docs example image reference to ghcr.io. |
| .github/workflows/go.yml | Set KPT_FN_WASM_RUNTIME=nodejs in the Linux CI test job. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
New WASM images published. It's a manual process now. Fix Go 1.21+ wasm compatibility by renaming the import module from go to gojs in the nodejs JS glue code. The wasmexec library used by the wasmtime runtime has the same issue but requires a separate upstream fix. Signed-off-by: aravind.est <aravindhan.a@est.tech>
aravindtga
force-pushed
the
replace-missing-gcr-to-ghcr
branch
from
620ebff to
dc7c8a2
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 32 out of 34 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates container image references from gcr.io to ghcr.io across documentation, test data, and test files.
The following references are preserved:
Additionally, this PR adds wasm function image support and fixes Go 1.21+ wasm compatibility: