Propositional Logic Response Area#7
Propositional Logic Response Area#7ashwin6-dev wants to merge 15 commits intolambda-feedback:mainfrom
Conversation
…plemented in evaluation_function)
…nge, full stringify or partial stringify
m-messer
left a comment
m-messer
left a comment
There was a problem hiding this comment.
Thanks for your work on this! I've add a few minor comments, and there is a little git cleanup that would be helpful to sort.
There was a problem hiding this comment.
Should this be commited as a change?
There was a problem hiding this comment.
Why was this workaround necessary? This would be good to feedback.
|
|
||
| const stored = raw as Partial<PersistedAnswer> | ||
|
|
||
| // let parsedTruthTable: PropositionalLogicAnswerSchema['truthTable'] = undefined |
There was a problem hiding this comment.
Try to remove commented out code
| return validated.data | ||
| } | ||
| } catch { | ||
| // corrupted JSON -> ignore |
| export const PROPOSITIONAL_LOGIC_SYMBOLS: PropositionalLogicSymbol[] = [ | ||
| { label: '¬', value: '¬', title: 'Not' }, | ||
| { label: '∧', value: '∧', title: 'And' }, | ||
| { label: '∨', value: '∨', title: 'Or' }, |
| { value: '⊥', label: '⊥ (false)' }, | ||
| ] | ||
|
|
||
| const SYMBOLS = [ |
There was a problem hiding this comment.
This is already defined in the Symbols file? Remove and import?
| import { SandboxResponseAreaTub } from './types/Sandbox/index' | ||
|
|
||
| // Create a QueryClient instance | ||
| const queryClient = new QueryClient({ |
There was a problem hiding this comment.
What is the query client used for?
There was a problem hiding this comment.
Should not be commited. Should use yarn instead of NPM to setup
There was a problem hiding this comment.
Same here, this should be using yarn instead of NPM
4 participants
Check
README.mdwithin thePropositionalLogicfolder for a short description of what this response area contains.Key External Changes
Some changes were made outside the
PropositionalLogicfolder.src/externals/styles/fonts.tsx- wasexternals/styles/fonts.tsx (1:37): "Roboto" is not exported by "node_modules/next/font/google/index.js"error with the original file. Current file injects Google Fonts CSS at runtime.src/sandbox-component.tsx- added a query client provider wrapper. Had aError: No QueryClient set, use QueryClientProvider to set onein the brower console otherwise. I think this is due to the fact this response area uses OmniInput.OmniInput Preview Issue To Look At
Currently, preview doesn't show anything. I changed the backend to return a fixed dummy value for now, but still the preview doesn't show anything, which makes me believe there is an issue in the frontend.
When hand drawing the input, there is a console error saying
Input processing error (draw): TypeError: fetchData(...) is not a function. Typing the input doesn't have this error, but still the preview is empty.In
externals/api/fetcher.ts,fetchDatareturnsnull, which I think is the issue, but I do not know how I should go from there.Other response areas that use OmniInput display previews fine in the sandbox.