fix: fix parameter constraints for LarkMessageTrigger#213
fix: fix parameter constraints for LarkMessageTrigger#213yballul-bytedance wants to merge 1 commit intolarksuite:mainfrom
Conversation
github-actions
bot
added
domain/base
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughUpdated Lark workflow docs: removed Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Greptile SummaryThis PR improves documentation accuracy for Lark Base workflow steps in two ways: non-branch Trigger/Action nodes now omit Confidence Score: 5/5Documentation-only PR, safe to merge with one minor wording inconsistency noted. All findings are P2 style suggestions on documentation text. The only issue is a minor inconsistency where skills/lark-base/references/lark-base-workflow-schema.md — Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[LarkMessageTrigger] --> B{receive_scene}
B -->|group 群聊| C[receiver: group/user/ref]
B -->|chat 单聊| D[receiver: user only]
C --> E[scope: at / all — 必填]
C --> F[sender_contains — 生效]
C --> G[is_new_message — 生效]
D --> H[scope — 请勿指定]
D --> I[sender_contains — 请勿指定]
D --> J[is_new_message — 请勿指定]
E --> K[filter: MessageFilter]
H --> K
Reviews (6): Last reviewed commit: "fix: 修正 LarkMessageTrigger 的参数限制" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@skills/lark-base/references/lark-base-workflow-schema.md`:
- Line 91: The schema text forbids setting children on Trigger/Action nodes but
the example workflow objects (AddRecordTrigger, LarkMessageAction,
SetRecordAction, GenerateAiTextAction) still include `"children": { "links": []
}`, causing a contradiction; update those example objects (and the similar
examples in lark-base-workflow-create.md, lark-base-workflow-get.md,
lark-base-workflow-update.md) to remove the children field from Trigger and
Action node examples and instead show chaining via the `next` property (or, if
the API actually requires an empty children object, update the guidance text to
state that children may be present but must be empty), ensuring consistency
between the guidance lines about Trigger/Action and the example payloads.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 8fafee7f-a90e-471b-8e8d-b7be3e2e4619
📒 Files selected for processing (1)
skills/lark-base/references/lark-base-workflow-schema.md
yballul-bytedance
force-pushed
the
fix/workflow-schema
branch
from
f9c51f7 to
34e3ce3
Compare
|
|
yballul-bytedance
force-pushed
the
fix/workflow-schema
branch
2 times, most recently
from
bf65044 to
02d91ff
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
skills/lark-base/references/lark-base-workflow-schema.md (1)
825-908:⚠️ Potential issue | 🟠 MajorUpdate examples to remove
childrenfield from Trigger and Action nodes across all documentation files.Verification found the main workflow example (lines 825-908) is correctly formatted. However, other examples in the documentation violate the updated guidance:
- lark-base-workflow-schema.md: Simple example at lines 14-19 incorrectly includes
"children": { "links": [] }on AddRecordTrigger- lark-base-workflow-create.md: Lines 71-84 show AddRecordTrigger and LarkMessageAction with
childrenfields- lark-base-workflow-get.md: Lines 116-128 show AddRecordTrigger and LarkMessageAction with
childrenfields- lark-base-workflow-update.md: Lines 79-92 show AddRecordTrigger and LarkMessageAction with
childrenfieldsOnly branch nodes (IfElseBranch) should include
children. Remove these fields from all Trigger and Action node examples to maintain consistency.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@skills/lark-base/references/lark-base-workflow-schema.md` around lines 825 - 908, Examples include extraneous "children" fields on Trigger/Action node examples; remove any "children" property from AddRecordTrigger, LarkMessageAction, SetRecordAction, GenerateAiTextAction (and any other trigger/action node examples) and leave "children" only on branch nodes like IfElseBranch; update the example JSON blocks so Trigger/Action objects do not contain "children": { "links": [...] } while preserving all other fields and existing IfElseBranch.children entries.
🧹 Nitpick comments (2)
skills/lark-base/references/lark-base-workflow-schema.md (2)
91-91: Minor: Add space after backtick for consistency.There's a missing space between the closing backtick of
childrenand the comma.✏️ Proposed fix
-所有 Trigger 节点**请勿设置** `children` ,通过 `next` 串联后继。 +所有 Trigger 节点**请勿设置** `children`,通过 `next` 串联后继。(Note: Alternatively, if you want a space before the comma, use:
children,)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@skills/lark-base/references/lark-base-workflow-schema.md` at line 91, The line mentioning Trigger nodes has a missing space after the closing backtick for `children`; update the markdown so there's a space before the comma (e.g., change "`children`, " to "`children`,") by editing the sentence that contains the symbol `children` to include the space for consistent punctuation spacing.
115-115: Minor: Add consistent spacing.Same spacing issue as line 91.
✏️ Proposed fix
-所有 Action 节点**请勿设置** `children` ,通过 `next` 串联后继。 +所有 Action 节点**请勿设置** `children`,通过 `next` 串联后继。🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@skills/lark-base/references/lark-base-workflow-schema.md` at line 115, The sentence "所有 Action 节点**请勿设置** `children` ，通过 `next` 串联后继。" has an extra space before the Chinese comma; update this line to use no space between the inline code `children` and the punctuation (make it "`children`，") to match the spacing used on line 91 and keep punctuation spacing consistent across the document.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@skills/lark-base/references/lark-base-workflow-schema.md`:
- Around line 263-268: The documentation marks the field `scope` as "必填" while
its description limits it to group scenarios only, creating a contradiction;
update the table row for `scope` so the "必填" column reflects a conditional
requirement (e.g., "有条件" or "群聊必填") or change it to "否" and add a clear
parenthetical note in the description of `scope` that it is required only when
`receive_scene` is `group` and must not be specified when `receive_scene` is
`chat`; also ensure related fields `receive_scene` and `receiver` remain
consistent with that conditional requirement.
---
Outside diff comments:
In `@skills/lark-base/references/lark-base-workflow-schema.md`:
- Around line 825-908: Examples include extraneous "children" fields on
Trigger/Action node examples; remove any "children" property from
AddRecordTrigger, LarkMessageAction, SetRecordAction, GenerateAiTextAction (and
any other trigger/action node examples) and leave "children" only on branch
nodes like IfElseBranch; update the example JSON blocks so Trigger/Action
objects do not contain "children": { "links": [...] } while preserving all other
fields and existing IfElseBranch.children entries.
---
Nitpick comments:
In `@skills/lark-base/references/lark-base-workflow-schema.md`:
- Line 91: The line mentioning Trigger nodes has a missing space after the
closing backtick for `children`; update the markdown so there's a space before
the comma (e.g., change "`children`, " to "`children`,") by editing the sentence
that contains the symbol `children` to include the space for consistent
punctuation spacing.
- Line 115: The sentence "所有 Action 节点**请勿设置** `children` ，通过 `next` 串联后继。" has
an extra space before the Chinese comma; update this line to use no space
between the inline code `children` and the punctuation (make it "`children`，")
to match the spacing used on line 91 and keep punctuation spacing consistent
across the document.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 50ab0bc4-f832-43ec-9864-ed60dc5e1a1b
📒 Files selected for processing (1)
skills/lark-base/references/lark-base-workflow-schema.md
yballul-bytedance
changed the title
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@02d91fff06cb994104eca30f83fd9e2bc8bdb670🧩 Skill updatenpx skills add yballul-bytedance/cli#fix/workflow-schema -y -g |
yballul-bytedance
force-pushed
the
fix/workflow-schema
branch
from
02d91ff to
5b4ac3e
Compare
Change-Id: Ib291b0c7817cb3e52e80d85dcf26993c7fab487c
yballul-bytedance
force-pushed
the
fix/workflow-schema
branch
from
5b4ac3e to
f4ccdbd
Compare
2 participants
Change-Id: Ib291b0c7817cb3e52e80d85dcf26993c7fab487c
Summary by CodeRabbit