-
Notifications
You must be signed in to change notification settings - Fork 383
fix: reject positional arguments in shortcuts #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MaxHuang22
wants to merge
2
commits into
main
Choose a base branch
from
fix/reject-positional-args
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+72
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| // Copyright (c) 2026 Lark Technologies Pte. Ltd. | ||
| // SPDX-License-Identifier: MIT | ||
|
|
||
| package common | ||
|
|
||
| import ( | ||
| "strings" | ||
| "testing" | ||
|
|
||
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| func TestRejectPositionalArgs_WithArgs(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| validator := rejectPositionalArgs() | ||
|
|
||
| err := validator(&cobra.Command{}, []string{"hello"}) | ||
| if err == nil { | ||
| t.Fatal("expected error for positional arg, got nil") | ||
| } | ||
| if !strings.Contains(err.Error(), "positional arguments are not supported") { | ||
| t.Errorf("expected positional args rejection message, got: %v", err) | ||
| } | ||
| if !strings.Contains(err.Error(), `"hello"`) { | ||
| t.Errorf("expected the positional arg value in error, got: %v", err) | ||
| } | ||
| } | ||
|
|
||
| func TestRejectPositionalArgs_MultipleArgs(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| validator := rejectPositionalArgs() | ||
|
|
||
| err := validator(&cobra.Command{}, []string{"hello", "world"}) | ||
| if err == nil { | ||
| t.Fatal("expected error for multiple positional args, got nil") | ||
| } | ||
| if !strings.Contains(err.Error(), "positional arguments are not supported") { | ||
| t.Errorf("unexpected error message: %v", err) | ||
| } | ||
| if !strings.Contains(err.Error(), "hello") || !strings.Contains(err.Error(), "world") { | ||
| t.Errorf("expected all positional args in error, got: %v", err) | ||
| } | ||
| } | ||
|
|
||
| func TestRejectPositionalArgs_NoArgs(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| validator := rejectPositionalArgs() | ||
|
|
||
| if err := validator(&cobra.Command{}, nil); err != nil { | ||
| t.Fatalf("expected no error for nil args, got: %v", err) | ||
| } | ||
| if err := validator(&cobra.Command{}, []string{}); err != nil { | ||
| t.Fatalf("expected no error for empty args, got: %v", err) | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.