test(discovery): improve service.py coverage to 91%#507
Merged
tcoratger merged 1 commit intoleanEthereum:mainfrom Apr 4, 2026
Merged
test(discovery): improve service.py coverage to 91%#507tcoratger merged 1 commit intoleanEthereum:mainfrom
tcoratger merged 1 commit intoleanEthereum:mainfrom
Conversation
…ew issues - Remove in-function imports per CLAUDE.md conventions - Merge duplicate *Extended test classes into primary classes - Remove redundant/weak tests - Fix weak assertions (>= 0 → >= 1) - Add test for bootstrap exception handling
Smartdevs17
changed the title
tcoratger
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve coverage for
src/lean_spec/subspecs/networking/discovery/service.pyfrom 61% to 91% (target ≥90%).What's covered
find_node()— Kademlia iterative lookup with parallel querying and iterative deepening_query_node()— FINDNODE query with distance handling_ping_node()— Ping and bond with success/failure paths_process_message()/_handle_message()— Message dispatch_handle_findnode()— FINDNODE handler with distance filtering_refresh_loop(),_revalidation_loop(),_cleanup_loop()with error resilience_process_discovered_enr()— ENR validation with distance mismatch, invalid ENR, own ENR, and dedup checks_bootstrap()— Bootnode initialization with exception handling_enr_to_entry()— ENR to node entry conversionTest Results
@tcoratger @unnawut
Closes #495