-
Notifications
You must be signed in to change notification settings - Fork 23
Streaming sync serialization #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bjester
wants to merge
10
commits into
learningequality:release-v0.9.x
Choose a base branch
from
bjester:streaming-sync
base: release-v0.9.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
336fcc8
Add property for quickly getting unique pairing ID
bjester cd21893
Prepare for more advanced and optimized iteration through app models
bjester ecd2c93
Move transaction helper to shared location
bjester dd659d8
Move model helper to shared location
bjester ee71780
Add foundational structure for streaming sync processing
bjester 8bfe235
Add test for model utility
bjester 50ae745
Refactor serialize step into new structure
bjester 82996d5
Migrate to serialize stream
bjester 8898125
Pin typing extensions to version that still supports 3.6
bjester af89f0d
Add documentation for streaming arch
bjester File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import logging | ||
| from contextlib import contextmanager | ||
|
|
||
| from django.db import connection | ||
| from django.db import transaction | ||
|
|
||
| from morango.sync.backends.utils import load_backend | ||
| from morango.sync.utils import lock_partitions | ||
|
|
||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
| DBBackend = load_backend(connection) | ||
|
|
||
|
|
||
| @contextmanager | ||
| def begin_transaction(sync_filter, isolated=False, shared_lock=False): | ||
| """ | ||
| Starts a transaction, sets the transaction isolation level to repeatable read, and locks | ||
| affected partitions | ||
|
|
||
| :param sync_filter: The filter for filtering applicable records of the sync | ||
| :type sync_filter: morango.models.certificates.Filter|None | ||
| :param isolated: Whether to alter the transaction isolation to repeatable-read | ||
| :type isolated: bool | ||
| :param shared_lock: Whether the advisory lock should be exclusive or shared | ||
| :type shared_lock: bool | ||
| """ | ||
| if isolated: | ||
| # when isolation is requested, we modify the transaction isolation of the connection for the | ||
| # duration of the transaction | ||
| with DBBackend._set_transaction_repeatable_read(): | ||
| with transaction.atomic(savepoint=False): | ||
| lock_partitions(DBBackend, sync_filter=sync_filter, shared=shared_lock) | ||
| yield | ||
| else: | ||
| with transaction.atomic(): | ||
| lock_partitions(DBBackend, sync_filter=sync_filter, shared=shared_lock) | ||
| yield |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not at all necessary, but the thought of being able to construct the pipeline with pipe operators amused me!