-
Notifications
You must be signed in to change notification settings - Fork 297
[DO NOT MERGE]: unstable to hotfixes, Q1 major release #5750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: hotfixes
Are you sure you want to change the base?
Changes from all commits
d9f08c3
8ce7058
d9586a6
1439c02
843b791
62171e4
c700935
4acb023
79ab0d3
4180024
a1d4c0f
72db464
fae142f
a97066d
d0f018a
bd94413
e2ecb2f
73148b6
4b50d30
5250ec6
e5b9ce5
a59dd08
d5468a9
e447340
cf8c2f3
ab1e8e0
6277ec6
5ad3c00
7ce4b4c
78f03fc
da5fb15
38a87a4
7ca5338
47b5fd7
be41d75
b106569
6dbfda7
d9c253c
8875fe1
4bc6ba3
a4704aa
87beccb
0c49081
9b42068
26f117a
409a8a6
aa3e54d
c9e3e4a
8504d85
5be7cf8
b317051
ed64e9e
e19fedb
4d59683
c978f65
b6c02dc
66cc53c
bd3a55b
246ac1d
7c491ad
9bd0eeb
1870526
d32d910
86b7487
0eb6de6
1dc6482
21f32ec
6654e7f
edf8769
2f2ce9a
e23f1f0
f6564c2
e13109c
f5dfe6c
8ebea0b
0b55c35
1e372fe
a548354
eaba504
eee1576
fdd5a84
5530d16
3c58c29
d509c37
218f8d7
4e8b3a0
addf9f5
637a344
5008c1e
ea3f6c9
b2f8755
11fa0af
2eab0a7
c553c57
ad4d81e
97e8172
02bb158
d8f7904
83dbd8c
a639c35
0e6df46
9b3276e
419277c
40081fe
0e89c39
49646dc
b26645b
635f665
2068975
95896e4
6f29e62
85d6fcc
f21d43c
56a67de
24c820a
9589f57
a6d4ba0
019ba43
c114591
40b32a2
ba2c207
e35d813
1caaeca
84145d2
b21a6f4
c4add77
57bb0cb
64e0548
4c99984
d831e0d
7bc2310
254877f
5e2b6d1
1ec4cb6
d0e98b1
b8e5720
7140688
256e2d8
afc7092
5b1cc28
a7d629b
6fb74cf
ade978b
eb3c5a3
ceacb29
6b9a271
f0387e3
311d6a0
fa86bf8
4a394de
64cce0f
ab9bd48
a0f3e79
94417df
266c1b0
0799417
8f5ddb3
af4223a
99ab4bb
6cbe9c4
929e49e
c3a369e
a8c5b55
db78166
1a3701d
e276410
661d675
d55f59a
5dc92e1
b3404d9
ebbf733
4f7569e
e033d2f
f0b08e3
8f60d97
3d9cae6
fe5ef92
327221d
26fa9ec
70321ae
97bdf41
3d240e5
d861343
6355010
13813dc
4f2a12a
53d2043
429975a
e01eee1
22478ad
4aebc0e
e54e72d
baac181
d6b9621
c270ce4
f2aa6e6
74341c4
22a5c2d
38a9805
c3d1cbe
2dd5003
e19fac7
f19d93c
568ae8c
d9b3f4d
60bd767
83efcdf
04d114c
362e4af
f8eac9e
83219f5
68f6102
4665226
3818aaa
90bdb6a
8339d18
1fba461
f17bbf6
f3bc749
dbc30f2
c7cf5ee
59a13aa
00b2506
082ed1b
677893f
48db1b7
b143bcd
740ea5d
1105aa9
cb656d2
279aa22
3525f8b
6bee301
eeb8d57
37147dd
1cb649a
3c6342c
b881d73
045277a
dfd820f
04095fa
3061264
93c3534
6f4929c
a08885e
42d8179
4a9a5d6
740dca2
6344d05
b57d722
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| name: Send reply on a new contributor pull request | ||
| on: | ||
| pull_request_target: | ||
| types: [opened] | ||
| jobs: | ||
| call-workflow: | ||
| name: Call shared workflow | ||
| uses: learningequality/.github/.github/workflows/contributor-pr-reply.yml@main | ||
| secrets: | ||
| LE_BOT_APP_ID: ${{ secrets.LE_BOT_APP_ID }} | ||
| LE_BOT_PRIVATE_KEY: ${{ secrets.LE_BOT_PRIVATE_KEY }} | ||
| SLACK_COMMUNITY_NOTIFICATIONS_WEBHOOK_URL: ${{ secrets.SLACK_COMMUNITY_NOTIFICATIONS_WEBHOOK_URL }} | ||
| Original file line number | Diff line number | Diff line change | |||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,11 @@ | |||||||||||||||||||||||
| name: Handle pull request events | |||||||||||||||||||||||
| on: | |||||||||||||||||||||||
| pull_request_target: | |||||||||||||||||||||||
| types: [review_requested, labeled] | |||||||||||||||||||||||
| jobs: | |||||||||||||||||||||||
| call-workflow: | |||||||||||||||||||||||
| name: Call shared workflow | |||||||||||||||||||||||
| uses: learningequality/.github/.github/workflows/pull-request-target.yml@main | |||||||||||||||||||||||
| secrets: | |||||||||||||||||||||||
| LE_BOT_APP_ID: ${{ secrets.LE_BOT_APP_ID }} | |||||||||||||||||||||||
| LE_BOT_PRIVATE_KEY: ${{ secrets.LE_BOT_PRIVATE_KEY }} | |||||||||||||||||||||||
|
Comment on lines
+7
to
+11
Check warningCode scanning / CodeQL Workflow does not contain permissions Medium
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
Copilot AutofixAI 2 days ago In general, the fix is to explicitly declare a Concretely, in permissions:
contents: readbetween line 1 (
Suggested changeset
1
.github/workflows/call-pull-request-target.yml
Copilot is powered by AI and may make mistakes. Always verify output.
Refresh and try again.
|
|||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,15 @@ | ||
| name: Update community pull requests spreadsheet | ||
| on: | ||
| pull_request_target: | ||
| types: [assigned,unassigned,opened,closed,reopened] | ||
| types: [assigned, unassigned, opened, closed, reopened, edited, review_requested, review_request_removed] | ||
|
|
||
| jobs: | ||
| call-update-spreadsheet: | ||
| call-workflow: | ||
| name: Call shared workflow | ||
| uses: learningequality/.github/.github/workflows/update-pr-spreadsheet.yml@main | ||
| secrets: | ||
| LE_BOT_APP_ID: ${{ secrets.LE_BOT_APP_ID }} | ||
| LE_BOT_PRIVATE_KEY: ${{ secrets.LE_BOT_PRIVATE_KEY }} | ||
| CONTRIBUTIONS_SPREADSHEET_ID: ${{ secrets.CONTRIBUTIONS_SPREADSHEET_ID }} | ||
| CONTRIBUTIONS_SHEET_NAME: ${{ secrets.CONTRIBUTIONS_SHEET_NAME }} | ||
| GH_UPLOADER_GCP_SA_CREDENTIALS: ${{ secrets.GH_UPLOADER_GCP_SA_CREDENTIALS }} | ||
Check warningCode scanning / CodeQL Workflow does not contain permissions Medium
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 3.10 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| STATUS_PENDING = "PENDING" | ||
| STATUS_APPROVED = "APPROVED" | ||
| STATUS_REJECTED = "REJECTED" | ||
| STATUS_SUPERSEDED = "SUPERSEDED" | ||
| STATUS_LIVE = "LIVE" | ||
|
|
||
| status_choices = ( | ||
| (STATUS_PENDING, "Pending"), | ||
| (STATUS_APPROVED, "Approved"), | ||
| (STATUS_REJECTED, "Rejected"), | ||
| (STATUS_SUPERSEDED, "Superseded"), | ||
| (STATUS_LIVE, "Live"), | ||
| ) | ||
|
|
||
| REASON_INVALID_LICENSING = "INVALID_LICENSING" | ||
| REASON_TECHNICAL_QUALITY_ASSURANCE = "TECHNICAL_QUALITY_ASSURANCE" | ||
| REASON_INVALID_METADATA = "INVALID_METADATA" | ||
| REASON_PORTABILITY_ISSUES = "PORTABILITY_ISSUES" | ||
| REASON_OTHER = "OTHER" | ||
|
|
||
| resolution_reason_choices = ( | ||
| (REASON_INVALID_LICENSING, "Invalid Licensing"), | ||
| (REASON_TECHNICAL_QUALITY_ASSURANCE, "Technical Quality Assurance"), | ||
| (REASON_INVALID_METADATA, "Invalid Metadata"), | ||
| (REASON_PORTABILITY_ISSUES, "Portability Issues"), | ||
| (REASON_OTHER, "Other"), | ||
| ) |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Copilot Autofix
AI 2 days ago
To fix this, explicitly declare
permissionsfor the job (or globally) so theGITHUB_TOKENis limited to the least privileges needed. Since this workflow only delegates to a reusable workflow and does not itself perform any repository writes, a safe, minimal default is read-only access to repository contents. That both satisfies CodeQL and avoids unintentionally granting write access via inherited defaults.The best fix, without changing existing functionality, is to add a
permissionsblock under thecall-workflowjob, e.g.:Placing it at the job level ensures the restriction applies specifically to this job, and avoids assumptions about other jobs (there are none currently, but this keeps the change tightly scoped). No imports or additional definitions are needed; this is a pure YAML configuration change within
.github/workflows/call-contributor-pr-reply.yml. Insert the newpermissionsblock betweencall-workflow:andname:with correct indentation.