fix: restore image mask for non-inpaint image to image#1390
Open
wbruna wants to merge 1 commit intoleejet:masterfrom
Open
fix: restore image mask for non-inpaint image to image#1390wbruna wants to merge 1 commit intoleejet:masterfrom
wbruna wants to merge 1 commit intoleejet:masterfrom
Conversation
wbruna
commented
Apr 5, 2026
| latents.ref_latents = std::move(ref_latents); | ||
|
|
||
| if (sd_version_is_inpaint(sd_ctx->sd->version)) { | ||
| if (!latents.init_latent.empty()) { |
Contributor
Author
There was a problem hiding this comment.
I initially did the full check:
sd_version_is_inpaint(sd_ctx->sd->version) || (!latents.init_latent.empty() && !latent_mask.empty())but inpaint models always need an input image anyway, and moving an empty mask over the empty result won't affect anything.
Contributor
|
This is also addressed by the updated version of #1357 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.