Closed
Conversation
seanm
reviewed
Nov 16, 2025
seanm
approved these changes
Nov 23, 2025
tormodvolden
requested changes
Feb 10, 2026
Contributor
tormodvolden
left a comment
tormodvolden
left a comment
There was a problem hiding this comment.
With some fixups this looks good.
Contributor
|
I pushed a fixup commit that I'll squash when merging. |
tormodvolden
approved these changes
Feb 19, 2026
sonatique
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the documents a couple of class codes are missing (reference: www.usb.org/defined-class-codes).
This pull request is related to issue #1716.