-
Notifications
You must be signed in to change notification settings - Fork 438
Rustfmt ChannelManager splice message handlers #4412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rustfmt ChannelManager splice message handlers #4412
Conversation
We have the same error being returned from several `ChannelManager` message handlers, so we DRY it up. Doing so also lets us get rid of the inlined `format!` call, which for some reason prevents `rustfmt` from formatting code around it.
We have the same error being returned from several `ChannelManager` API methods, so we DRY it up. Doing so also lets us get rid of the inlined `format!` call, which for some reason prevents `rustfmt` from formatting code around it.
|
I've assigned @tankyleo as a reviewer! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4412 +/- ##
==========================================
+ Coverage 86.05% 86.06% +0.01%
==========================================
Files 156 156
Lines 103384 103454 +70
Branches 103384 103454 +70
==========================================
+ Hits 88971 89042 +71
+ Misses 11900 11896 -4
- Partials 2513 2516 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheBlueMatt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's random formatting in the first two prefactors which is weird.
That's because the formatter wasn't actually being applied due to the inlined macro call. |
Should we squash all the rustfmt commits into one to keep the git history tidier?