Zero page->private when freeing pages#584
Open
blktests-ci[bot] wants to merge 11 commits intolinus-master_basefrom
Open
Zero page->private when freeing pages#584blktests-ci[bot] wants to merge 11 commits intolinus-master_basefrom
blktests-ci[bot] wants to merge 11 commits intolinus-master_basefrom
Conversation
Author
|
Upstream branch: 32a92f8 |
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
50e7070 to
c90f83b
Compare
Author
|
Upstream branch: 6de23f8 |
blktests-ci
bot
force-pushed
the
series/1056249=>linus-master
branch
from
2696d00 to
167146a
Compare
Author
|
Upstream branch: 6de23f8 |
blktests-ci
bot
force-pushed
the
series/1056249=>linus-master
branch
from
167146a to
6bfae31
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
c90f83b to
c475e20
Compare
Author
|
Upstream branch: 7dff99b |
blktests-ci
bot
force-pushed
the
series/1056249=>linus-master
branch
from
6bfae31 to
0d28735
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
c475e20 to
14f6b99
Compare
Author
|
Upstream branch: a75cb86 |
blktests-ci
bot
force-pushed
the
series/1056249=>linus-master
branch
from
0d28735 to
12121c3
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
14f6b99 to
856dc37
Compare
Author
|
Upstream branch: 4d349ee |
blktests-ci
bot
force-pushed
the
series/1056249=>linus-master
branch
from
12121c3 to
29fd160
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
856dc37 to
40967f0
Compare
Author
|
Upstream branch: 11439c4 |
blktests-ci
bot
force-pushed
the
series/1056249=>linus-master
branch
from
29fd160 to
5020cdd
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
40967f0 to
d4e9bad
Compare
Author
|
Upstream branch: af4e9ef |
blktests-ci
bot
force-pushed
the
series/1056249=>linus-master
branch
from
5020cdd to
8bd4415
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
d4e9bad to
ecd10e2
Compare
blktests-ci
bot
force-pushed
the
series/1056249=>linus-master
branch
from
8bd4415 to
0873359
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
d0e1bed to
6b51c57
Compare
Author
|
Upstream branch: 0031c06 |
blktests-ci
bot
force-pushed
the
series/1056249=>linus-master
branch
from
0873359 to
4d2038c
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
6b51c57 to
78036b2
Compare
Author
|
Upstream branch: ecc64d2 |
blktests-ci
bot
force-pushed
the
series/1056249=>linus-master
branch
from
4d2038c to
f7457bd
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
78036b2 to
bbb3394
Compare
Author
|
Upstream branch: c107785 |
blktests-ci
bot
force-pushed
the
series/1056249=>linus-master
branch
from
f7457bd to
02cb31c
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
bbb3394 to
901a429
Compare
Author
|
Upstream branch: 5ee8dbf |
blktests-ci
bot
force-pushed
the
series/1056249=>linus-master
branch
from
02cb31c to
6f770f1
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
901a429 to
1f19ba6
Compare
Author
|
Upstream branch: 1f318b9 |
blktests-ci
bot
force-pushed
the
series/1056249=>linus-master
branch
from
6f770f1 to
0d7d094
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
1f19ba6 to
e79276a
Compare
This prepares for upcoming page->private checks in page freeing path. Signed-off-by: Zi Yan <ziy@nvidia.com> Cc: Jason Xing <kernelxing@tencent.com> Cc: Yushan Zhou <katrinzhou@tencent.com> Cc: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
This prepares for upcoming checks in page freeing path. Signed-off-by: Zi Yan <ziy@nvidia.com> Cc: Vlastimil Babka <vbabka@kernel.org> Cc: Christoph Lameter <cl@gentwo.org> Cc: David Rientjes <rientjes@google.com> Cc: Roman Gushchin <roman.gushchin@linux.dev> Cc: Harry Yoo <harry.yoo@oracle.com> Cc: linux-mm@kvack.org
This prepares upcoming checks in page freeing path. Signed-off-by: Zi Yan <ziy@nvidia.com> Cc: Christian Koenig <christian.koenig@amd.com> Cc: Huang Rui <ray.huang@amd.com> Cc: Matthew Auld <matthew.auld@intel.com> Cc: Matthew Brost <matthew.brost@intel.com> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Maxime Ripard <mripard@kernel.org> Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: David Airlie <airlied@gmail.com> Cc: Simona Vetter <simona@ffwll.ch> Cc: dri-devel@lists.freedesktop.org Acked-by: Christian König <christian.koenig@amd.com>
This prepares for upcoming checks in page freeing path. Signed-off-by: Zi Yan <ziy@nvidia.com> Cc: Jens Axboe <axboe@kernel.dk> Cc: linux-block@vger.kernel.org
This prepares for upcoming checks in page freeing path. Signed-off-by: Zi Yan <ziy@nvidia.com> Cc: Christian Brauner <brauner@kernel.org> Cc: K Prateek Nayak <kprateek.nayak@amd.com> Cc: Davidlohr Bueso <dave@stgolabs.net> Cc: Eric Sandeen <sandeen@redhat.com>
This prepares for upcoming checks in page freeing path. Signed-off-by: Zi Yan <ziy@nvidia.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: "Arve Hjønnevåg" <arve@android.com> Cc: Todd Kjos <tkjos@android.com> Cc: Christian Brauner <brauner@kernel.org> Cc: Carlos Llamas <cmllamas@google.com> Cc: Alice Ryhl <aliceryhl@google.com>
This prepares for upcoming checks in page freeing path. Signed-off-by: Zi Yan <ziy@nvidia.com> Cc: Jens Axboe <axboe@kernel.dk> Cc: Damien Le Moal <dlemoal@kernel.org> Cc: Johannes Thumshirn <johannes.thumshirn@wdc.com> Cc: linux-block@vger.kernel.org
This prepares for upcoming checks in page freeing path. Signed-off-by: Zi Yan <ziy@nvidia.com> Cc: Dennis Zhou <dennis@kernel.org> Cc: Tejun Heo <tj@kernel.org> Cc: Christoph Lameter <cl@gentwo.org> Cc: linux-mm@kvack.org
This prepares for upcoming checks in page freeing path. Signed-off-by: Zi Yan <ziy@nvidia.com> Cc: Gao Xiang <xiang@kernel.org> Cc: Yue Hu <zbestahu@gmail.com> Cc: Jeffle Xu <jefflexu@linux.alibaba.com> Cc: Sandeep Dhavale <dhavale@google.com> Cc: Hongbo Li <lihongbo22@huawei.com> Cc: Chunhai Guo <guochunhai@vivo.com> Cc: linux-erofs@lists.ozlabs.org
Author
|
Upstream branch: None |
page->private should not be set in tail pages. Commit 4265d67 ("mm/migrate_device: add THP splitting during migration") removed it without a proper reason. Add it back. Signed-off-by: Zi Yan <ziy@nvidia.com> Cc: David Hildenbrand <david@kernel.org> Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com> Cc: Baolin Wang <baolin.wang@linux.alibaba.com> Cc: "Liam R. Howlett" <Liam.Howlett@oracle.com> Cc: Nico Pache <npache@redhat.com> Cc: Ryan Roberts <ryan.roberts@arm.com> Cc: Dev Jain <dev.jain@arm.com> Cc: Barry Song <baohua@kernel.org> Cc: Lance Yang <lance.yang@linux.dev> Cc: linux-mm@kvack.org
Any user is supposed to zero their allocated page->private at free time, including both head and tail pages if the freed page is compound. Add VM_WARN_ON_ONCE to check page->private. Whoever encountering warnings from this commit needs to fix code that does not zero ->private when freeing a page/folio. Signed-off-by: Zi Yan <ziy@nvidia.com> Cc: Vlastimil Babka <vbabka@kernel.org> Cc: Suren Baghdasaryan <surenb@google.com> Cc: Michal Hocko <mhocko@suse.com> Cc: Brendan Jackman <jackmanb@google.com> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: linux-mm@kvack.org
blktests-ci
bot
force-pushed
the
series/1056249=>linus-master
branch
from
0d7d094 to
21e5c86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: Zero page->private when freeing pages
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1056249