Enable lock context analysis#619
Open
blktests-ci[bot] wants to merge 14 commits intolinus-master_basefrom
Open
Enable lock context analysis#619blktests-ci[bot] wants to merge 14 commits intolinus-master_basefrom
blktests-ci[bot] wants to merge 14 commits intolinus-master_basefrom
Conversation
Author
|
Upstream branch: ecc64d2 |
Author
|
Upstream branch: ecc64d2 |
blktests-ci
bot
force-pushed
the
series/1061541=>linus-master
branch
from
e52183e to
afbdff3
Compare
Author
|
Upstream branch: ecc64d2 |
blktests-ci
bot
force-pushed
the
series/1061541=>linus-master
branch
from
afbdff3 to
dce2c9a
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
78036b2 to
bbb3394
Compare
Author
|
Upstream branch: c107785 |
blktests-ci
bot
force-pushed
the
series/1061541=>linus-master
branch
from
dce2c9a to
e2cb4e7
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
bbb3394 to
901a429
Compare
Author
|
Upstream branch: 5ee8dbf |
blktests-ci
bot
force-pushed
the
series/1061541=>linus-master
branch
from
e2cb4e7 to
0e2f11f
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
901a429 to
1f19ba6
Compare
Author
|
Upstream branch: 1f318b9 |
blktests-ci
bot
force-pushed
the
series/1061541=>linus-master
branch
from
0e2f11f to
427f9ac
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
1f19ba6 to
e79276a
Compare
Make drbd_adm_dump_devices() call rcu_read_lock() before rcu_read_unlock() is called. This has been detected by the Clang thread-safety analyzer. Compile-tested only. Tested-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com> Cc: Andreas Gruenbacher <agruen@linbit.com> Fixes: a55bbd3 ("drbd: Backport the "status" command") Signed-off-by: Bart Van Assche <bvanassche@acm.org>
The Clang thread-safety analyzer does not support testing return values with "< 0". Hence change the "< 0" test into "!= 0". This is fine since the radix_tree_maybe_preload() return value is <= 0. Cc: Yu Kuai <yukuai3@huawei.com> Cc: Jan Kara <jack@suse.cz> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Clang is more strict than sparse with regard to lock context annotation checking. Hence this patch that makes the lock context annotations compatible with Clang. __release() annotations have been added below invocations of indirect calls that unlock a mutex because Clang does not support annotating function pointers with __releases(). Enable context analysis in the block layer Makefile. Signed-off-by: Bart Van Assche <bvanassche@acm.org>
ktio() unlocks and locks iocq[id].lock. Add a __must_hold() annotation that reflects this. This annotation prevents that Clang will complain about this function once lock context analysis is enabled. Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Clang performs more strict checking of lock context annotations than sparse. This patch makes the DRBD lock context annotations compatible with Clang and prepares for enabling lock context analysis. Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Prepare for enabling lock context analysis by adding lock context annotations that are compatible with Clang. Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Prepare for enabling lock context analysis by adding those lock context annotations that are required by Clang. Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Prepare for enabling lock context analysis by adding the lock context annotations that are required by Clang. Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Prepare for enabling lock context analysis by adding the lock context annotations that are required by Clang. Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Prepare for enabling lock context analysis by adding the lock context annotations required by Clang. Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Add the lock context annotations that are required by Clang. Remove the __must_hold(&ub->mutex) annotation from ublk_mark_io_ready() because not all callers hold ub->mutex. Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Author
|
Upstream branch: None |
Prepare for enabling lock context analysis by adding a lock context annotation that is required for Clang. Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Prepare for enabling lock context analysis by adding the lock context annotations that are required by Clang. Signed-off-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Now that all locking functions in block drivers have been annotated, enable lock context analysis for all block drivers. Signed-off-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org> # zram
blktests-ci
bot
force-pushed
the
series/1061541=>linus-master
branch
from
427f9ac to
a4132f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: Enable lock context analysis
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1061541