blk-cgroup: wait for blkcg cleanup before initializing new disk#625
Open
blktests-ci[bot] wants to merge 1 commit intolinus-master_basefrom
Open
blk-cgroup: wait for blkcg cleanup before initializing new disk#625blktests-ci[bot] wants to merge 1 commit intolinus-master_basefrom
blktests-ci[bot] wants to merge 1 commit intolinus-master_basefrom
Conversation
Author
|
Upstream branch: 1f318b9 |
Author
|
Upstream branch: 1f318b9 |
blktests-ci
bot
force-pushed
the
series/1063567=>linus-master
branch
from
b5dff09 to
87822d8
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
1f19ba6 to
e79276a
Compare
Author
|
Upstream branch: None |
blktests-ci
bot
force-pushed
the
series/1063567=>linus-master
branch
from
87822d8 to
106f9e2
Compare
Author
|
Upstream branch: None |
blktests-ci
bot
force-pushed
the
series/1063567=>linus-master
branch
from
106f9e2 to
9860114
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
e79276a to
0dd9afc
Compare
Author
|
Upstream branch: 80234b5 |
blktests-ci
bot
force-pushed
the
series/1063567=>linus-master
branch
from
9860114 to
a8dcfd3
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
0dd9afc to
2e598ed
Compare
When a queue is shared across disk rebind (e.g., SCSI unbind/bind), the previous disk's blkcg state is cleaned up asynchronously via disk_release() -> blkcg_exit_disk(). If the new disk's blkcg_init_disk() runs before that cleanup finishes, we may overwrite q->root_blkg while the old one is still alive, and radix_tree_insert() in blkg_create() fails with -EEXIST because the old blkg entries still occupy the same queue id slot in blkcg->blkg_tree. This causes the sd probe to fail with -ENOMEM. Fix it by waiting in blkcg_init_disk() for root_blkg to become NULL, which indicates the previous disk's blkcg cleanup has completed. Fixes: 1059699 ("block: move blkcg initialization/destroy into disk allocation/release handler") Cc: Yi Zhang <yi.zhang@redhat.com> Signed-off-by: Ming Lei <ming.lei@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de>
Author
|
Upstream branch: 0257f64 |
blktests-ci
bot
force-pushed
the
series/1063567=>linus-master
branch
from
a8dcfd3 to
fd75f1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: blk-cgroup: wait for blkcg cleanup before initializing new disk
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1063567