zram: do not permit params change after init#626
Open
blktests-ci[bot] wants to merge 1 commit intolinus-master_basefrom
Open
zram: do not permit params change after init#626blktests-ci[bot] wants to merge 1 commit intolinus-master_basefrom
blktests-ci[bot] wants to merge 1 commit intolinus-master_basefrom
Conversation
Author
|
Upstream branch: 1f318b9 |
Author
|
Upstream branch: 1f318b9 |
blktests-ci
bot
force-pushed
the
series/1064112=>linus-master
branch
from
4d4ce43 to
a192c2a
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
1f19ba6 to
e79276a
Compare
Author
|
Upstream branch: None |
First, algorithm_params_store(), like any sysfs handler, should grab device init lock. Second, like any write() sysfs handler, it should grab device init lock in exclusive mode. Third, it should not permit change of algos' parameters after device init, as this doesn't make sense - we cannot compress with one C/D dict and then just change C/D dict to a different one, for example. Fixes: 4eac932 ("zram: introduce algorithm_params device attribute") Cc: gao xu <gaoxu2@honor.com> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org> Acked-by: Brian Geffon <bgeffon@google.com>
blktests-ci
bot
force-pushed
the
series/1064112=>linus-master
branch
from
a192c2a to
b91bd2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: zram: do not permit params change after init
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1064112