Add Windows support to meson build system#3129
Add Windows support to meson build system#3129bcapener wants to merge 1 commit intolinux-nvme:masterfrom
Conversation
|
BTW, feel free to send the cleanup patches, e.g. the fix spelling stuff. This can go in independent of the windows port. |
bcapener
force-pushed
the
initial-windows-support-for-meson-build-system
branch
from
f1ba8b4 to
fe0d6bd
Compare
bcapener
force-pushed
the
initial-windows-support-for-meson-build-system
branch
from
fe0d6bd to
31fc277
Compare
|
I've just looked at Postgresql. This looks very clean. I think we should also adapt this pattern: elif host_system == 'freebsd'
sema_kind = 'unnamed_posix'
elif host_system == 'linux'
sema_kind = 'unnamed_posix'
cppflags += '-D_GNU_SOURCE'
|
do you mean get rid of |
bcapener
force-pushed
the
initial-windows-support-for-meson-build-system
branch
from
3102ce5 to
d9415cc
Compare
|
Yes, I think we should look how other project have solved these problems. Sure this is not a big thing, just saying we can steal from other projects :) |
meson.build
Outdated
|
|
||
| feature_python = get_option('python') | ||
| if feature_python.disabled() | ||
| if is_windows or feature_python.disabled() |
There was a problem hiding this comment.
FWIW, I started to work on the disable fabrics configuration option and all the library checks would be covered by this. So it wouldn't be platform dependent. This would be way cleaner I'd say.
see #3170
| else | ||
| generated_h = 'accessors.h' | ||
| generated_c = 'accessors.c' | ||
| generated_ld = 'accessors.ld' |
There was a problem hiding this comment.
btw, we are going to move the header generation out of the main build. instead it will be manually run. makes the build setup a bit simpler, so our hope.
Restructure meson.build files to support windows (msys2). This is the first step in the windows port and does not generate a useful executalbe. Signed-off-by: Brandon Capener <bcapener@micron.com> remove is_windows and add host_system
bcapener
force-pushed
the
initial-windows-support-for-meson-build-system
branch
from
d9415cc to
2cacbce
Compare
2 participants
feature: add windows support to meson build system
This is the first step in adding Windows build support to this project. The idea is to restructure the meson.build files to support windows without touching any of the code.
Signed-off-by: Brandon Capener bcapener@micron.com