Skip to content

chore: extend copyright year to 2026#620

Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:develop/eaglefrom
GongHeng2017:202603171416-dev-eagle-fix
Mar 18, 2026
Merged

chore: extend copyright year to 2026#620
deepin-bot[bot] merged 1 commit intolinuxdeepin:develop/eaglefrom
GongHeng2017:202603171416-dev-eagle-fix

Conversation

@GongHeng2017
Copy link
Contributor

@GongHeng2017 GongHeng2017 commented Mar 17, 2026

Summary by Sourcery

Chores:

  • Refresh SPDX-FileCopyrightText year range to 2022–2026 in commonfunction and main source/header files.

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 17, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates SPDX-FileCopyrightText headers in deepin-devicemanager source files to extend the covered years from a single year (2022) to the range 2022–2026, keeping licensing otherwise unchanged.

File-Level Changes

Change Details Files
Extend SPDX copyright year range from 2022 to 2022–2026 in core source files.
  • Updated SPDX-FileCopyrightText header to use a year range instead of a single year while preserving owner name and formatting.
  • Ensured GPL-3.0-or-later SPDX license identifier comment remains unchanged.
deepin-devicemanager/src/commonfunction.cpp
deepin-devicemanager/src/commonfunction.h
deepin-devicemanager/src/main.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions
Copy link

  • 敏感词检查失败, 检测到1个文件存在敏感词
详情
{
    "deepin-devicemanager/src/main.cpp": [
        {
            "line": "        const QString acknowledgementLink = \"https://www.deepin.org/original/device-manager/\";",
            "line_number": 90,
            "rule": "S35",
            "reason": "Url link | 9d824dc221"
        }
    ]
}

@GongHeng2017 GongHeng2017 force-pushed the 202603171416-dev-eagle-fix branch from 3ece3d2 to 303b1e5 Compare March 17, 2026 13:02
@deepin-ci-robot
Copy link

deepin pr auto review

这段代码 diff 主要展示了版权声明(SPDX 标签)的更新。以下是对该变更的审查意见:

1. 语法逻辑

  • 审查结果通过
  • 分析:变更内容仅涉及文件头部的注释文本,不包含任何可执行代码。因此不存在语法错误或逻辑问题。

2. 代码质量

  • 审查结果通过
  • 分析
    • 此次变更统一了文件头部的版权声明格式,移除了旧的 // Copyright (C)... 风格的声明,统一采用 REUSE 规范推荐的 SPDX-FileCopyrightText 标签。
    • 将版权年份更新为 2022 - 2026,符合软件维护周期的预期。
    • 保留了 SPDX-License-Identifier: GPL-3.0-or-later,确保了开源协议声明的准确性。
    • 这种规范化修改有助于提高项目的合规性和可维护性。

3. 代码性能

  • 审查结果不适用
  • 分析:由于修改仅限于注释部分,不涉及任何代码逻辑、算法或数据结构的变更,因此对程序的运行时性能、内存占用或编译产物没有任何影响。

4. 代码安全

  • 审查结果:通过**。
  • 分析
    • 修改内容为纯文本注释,不涉及函数调用、数据处理或系统交互,因此不会引入安全漏洞(如缓冲区溢出、注入攻击等)。
    • 版权声明的更新属于元数据维护,不影响软件的安全属性。

总结与建议

这段 diff 是一次纯粹的版权声明规范化更新,符合开源项目(如 REUSE Initiative)的最佳实践。

建议:

  1. 一致性:请确保项目中其他源文件(.cpp, .h 等)也同步更新为相同的版权声明格式,以保持整个仓库的一致性。
  2. 自动化检查:建议在 CI/CD 流程中集成 reuse lint 或类似的工具,以便在未来自动检测版权声明和许可证的一致性,避免人工遗漏。
  3. 年份范围:确认 2026 年是否为预期的维护截止年份。通常建议使用当前年份或未来较近的年份,或者如果项目长期维护,也可以使用 2022 - present(取决于具体规范要求,但在代码中写死具体年份也是常见做法)。

@github-actions
Copy link

  • 敏感词检查失败, 检测到1个文件存在敏感词
详情
{
    "deepin-devicemanager/src/main.cpp": [
        {
            "line": "        const QString acknowledgementLink = \"https://www.deepin.org/original/device-manager/\";",
            "line_number": 89,
            "rule": "S35",
            "reason": "Url link | 9d824dc221"
        }
    ]
}

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GongHeng2017, max-lvs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GongHeng2017
Copy link
Contributor Author

/forcemerger

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Mar 18, 2026

This pr force merged! (status: unstable)

@deepin-bot deepin-bot bot merged commit 5ebbef8 into linuxdeepin:develop/eagle Mar 18, 2026
18 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants