Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| req.new_video_source.type = proto_video.VideoSourceType.VIDEO_SOURCE_NATIVE | ||
| req.new_video_source.resolution.width = width | ||
| req.new_video_source.resolution.height = height | ||
| req.new_video_source.is_screencast = is_screencast |
There was a problem hiding this comment.
🔴 Setting is_screencast on protobuf message that lacks this field causes AttributeError at runtime
The code sets req.new_video_source.is_screencast = is_screencast on line 29, but the NewVideoSourceRequest protobuf message does not have an is_screencast field. This causes an AttributeError every time VideoSource.__init__ is called, making the class completely unusable.
Root Cause
The protobuf definition for NewVideoSourceRequest only has two fields: type and resolution (confirmed in livekit-rtc/livekit/rtc/_proto/video_frame_pb2.pyi:242-265 and verified at runtime). The PR adds req.new_video_source.is_screencast = is_screencast but the corresponding .proto file was never updated to include the is_screencast field.
Runtime verification:
>>> msg = video_frame_pb2.NewVideoSourceRequest()
>>> msg.is_screencast = True
AttributeError: Protocol message NewVideoSourceRequest has no "is_screencast" field.
Impact: Every call to VideoSource(width, height) — even without passing is_screencast — will crash with AttributeError because False (the default) is still assigned to the non-existent field. This is a complete regression that breaks all video source creation.
Prompt for agents
The protobuf definition for NewVideoSourceRequest in video_frame_pb2.py needs to be regenerated from an updated .proto file that includes the is_screencast field. The .proto file (likely video_frame.proto) should add a field like `optional bool is_screencast = 3;` to the NewVideoSourceRequest message. Then regenerate the Python protobuf bindings (video_frame_pb2.py and video_frame_pb2.pyi). Without this proto update, the line `req.new_video_source.is_screencast = is_screencast` in video_source.py:29 will always raise an AttributeError at runtime.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
No description provided.