Open
Conversation
Installs each package's dependencies before benchmarking to improve go-to-definition accuracy. Tries requirements.txt, then pyproject.toml dependencies. Includes test CI workflow on feat/install-deps-benchmark.
Replace custom install_package_deps with the typecheck benchmark's install_deps function and install_envs.json config. Add missing packages (kivy, wagtail, pyarrow, ujson, sphinx, pyopengl) to both install_envs.json and KNOWN_GITHUB_URLS.
…kages Remove KNOWN_GITHUB_URLS, get_fallback_packages, load_prioritized_packages, and resolve_github_url from LSP daily_runner. Replace with load_packages_from_install_envs() which reads from typecheck_benchmark/install_envs.json — the same file used by the typecheck benchmark. Both benchmarks now always use the same packages. Update tests and both CI workflows accordingly.
Fix NoneType.startswith error in test by adding explicit None check. Update CLAUDE.md with pre-commit checklist (pytest, pyrefly, tsc), shared package config architecture, and project structure docs.
Only include packages with install:true or non-empty deps list, matching the typecheck_benchmark.daily_runner.load_install_envs() filter. Previous code returned all 84 packages causing timeout. Increase CI timeout to 360 minutes for 58 packages. Fix tests to include install config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.