Add --runs flag to typecheck benchmark daily runner#131
Open
yangdanny97 wants to merge 1 commit intololpack:mainfrom
Open
Add --runs flag to typecheck benchmark daily runner#131yangdanny97 wants to merge 1 commit intololpack:mainfrom
yangdanny97 wants to merge 1 commit intololpack:mainfrom
Conversation
Owner
|
I worry about the length of these runs already. Is there another approach that doesn't make this take X times longer? |
Collaborator
Author
|
You could shard the runs so that we check 20-25 packages per shard something, and merge the results later. That's what we do for mypy primer |
Collaborator
Author
|
We should probably also do a warmup run where we throw away the results, to reduce variance further |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single run per day seems like it could be noisy, maybe we can do 3 or 5 runs for more stable results. The job already takes 2 hours so we probably shouldn't do more than that
Example run