Skip to content

Add --runs flag to typecheck benchmark daily runner#131

Open
yangdanny97 wants to merge 1 commit intololpack:mainfrom
yangdanny97:main
Open

Add --runs flag to typecheck benchmark daily runner#131
yangdanny97 wants to merge 1 commit intololpack:mainfrom
yangdanny97:main

Conversation

@yangdanny97
Copy link
Collaborator

@yangdanny97 yangdanny97 commented Mar 17, 2026

A single run per day seems like it could be noisy, maybe we can do 3 or 5 runs for more stable results. The job already takes 2 hours so we probably shouldn't do more than that

Example run

  python3 -m typecheck_benchmark \
    --packages 5 \
    --checkers pyright pyrefly ty mypy zuban \
    --runs 3 \
    --timeout 300 \
    --output typecheck_benchmark/results \
    --os-name macos

@yangdanny97 yangdanny97 requested a review from lolpack March 17, 2026 14:47
@lolpack
Copy link
Owner

lolpack commented Mar 17, 2026

I worry about the length of these runs already. Is there another approach that doesn't make this take X times longer?

@yangdanny97
Copy link
Collaborator Author

yangdanny97 commented Mar 17, 2026

You could shard the runs so that we check 20-25 packages per shard something, and merge the results later.

That's what we do for mypy primer

@yangdanny97
Copy link
Collaborator Author

We should probably also do a warmup run where we throw away the results, to reduce variance further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants